adamsaghy commented on code in PR #2505:
URL: https://github.com/apache/fineract/pull/2505#discussion_r943746986
##########
fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandSource.java:
##########
@@ -72,16 +71,24 @@ public class CommandSource extends
AbstractPersistableCustom {
@JoinColumn(name = "maker_id", nullable = false)
private AppUser maker;
- @Column(name = "made_on_date", nullable = false)
- private LocalDateTime madeOnDate;
+ /*
+ * Deprecated: Columns and data left untouched to help migration.
+ *
+ * @Column(name = "made_on_date", nullable = false) private LocalDateTime
madeOnDate;
+ *
+ * @Column(name = "checked_on_date", nullable = true) private
LocalDateTime checkedOnDate;
+ */
+
+ @Column(name = "made_on_utc", nullable = false)
Review Comment:
You have eagle eyes. I was wondering change the native query instead. I
started this kind of naming convention with all the new fields i have added,
like: created_on_utc,
created_by,...
Basically, i am leaving out the type, like: id, date, ...
Would you mind if i stick to the column name but would change in the native
query the alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
