adamsaghy commented on code in PR #2507:
URL: https://github.com/apache/fineract/pull/2507#discussion_r945988288


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java:
##########
@@ -1040,4 +970,21 @@ public String 
postLoanRepaymentTemplate(@FormDataParam("file") InputStream uploa
                 uploadedInputStream, fileDetail, locale, dateFormat);
         return this.toApiJsonSerializer.serialize(importDocumentId);
     }
+
+    @GET
+    @Path("{loanId}/delinquencytags")
+    @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+    @Produces(MediaType.APPLICATION_JSON)
+    @Operation(summary = "Retrieve the Loan Delinquency Tag history using the 
Loan Id", description = "")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = 
@Content(schema = @Schema(implementation = 
DelinquencyApiResourceSwagger.GetDelinquencyTagHistoryResponse.class))) })

Review Comment:
   I was just wondering if the response is a list, the swagger should reflect 
that as well
   
   `@ApiResponses(
     value = {
       @ApiResponse(
         content = {
           @Content(
             array = @ArraySchema(schema = @Schema(implementation = 
DelinquencyApiResourceSwagger.GetDelinquencyTagHistoryResponse.class)))
         })
     })`
     
     Something like above? Or am i wrong here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to