galovics commented on code in PR #2495:
URL: https://github.com/apache/fineract/pull/2495#discussion_r946931301
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -837,6 +849,10 @@ public LocalDate getSubmittedOnDate() {
return submittedOnDate;
}
+ public void setReversalExternalId(String reversalExternalId) {
Review Comment:
I don't think we wanna allow to override the reversal external ID once its
set, do we?
I feel the reverse method should be more than enough to provide the reversal
external ID.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/TextUtils.java:
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.core.service;
+
+import org.apache.commons.lang3.StringUtils;
+
+public final class TextUtils {
+
+ private TextUtils() {}
+
+ public static boolean is(final String commandParam, final String
commandValue) {
Review Comment:
I see you extracted this from the other class.
I think the TextUtils is very generic, it rather should be something like
CommandParameterUtil or something with a more descriptive name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
