adamsaghy opened a new pull request, #2576: URL: https://github.com/apache/fineract/pull/2576
## Description With the database structure in place for loan account locks, we need to utilize it. In this story, we need to create a new Spring Batch step (not business steps) and add it into the Loan COB job. The new step will be locking the loan accounts. Also, at the end of the execution of the business steps, we need to unlock the loan accounts within the chunk (it’s important to do it in the same transaction as the business steps). **Acceptance criteria** A new lock loan accounts Spring Batch step is introduced The lock loan accounts step locks the loan accounts which are in the chunk meaning that rows need to be inserted into the lock table A new unlock loan accounts mechanism is introduced The unlock loan accounts mechanism unlocks the loan accounts which are in the chunk meaning that rows need to be deleted from the lock table The lock loan accounts step is in the beginning of the execution, before executing the business steps The unlock loan accounts step is at the end of the business step execution in the same transaction If there was an error during processing a loan account, the exception shall be written in the corresponding lock row for later analysis The lock_owner column is filled properly with LOAN_COB_CHUNK_PROCESSING **Note** Skipping for the Spring Batch step shall be enabled A SkipListener could be useful ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
