This is an automated email from the ASF dual-hosted git repository.
arnold pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new fa169bb5d FINERACT-1694: Documentation for Reliable event framework
fa169bb5d is described below
commit fa169bb5d425df642ac9a9dc81150ced04cd52f8
Author: Arnold Galovics <[email protected]>
AuthorDate: Wed Sep 7 21:29:35 2022 +0200
FINERACT-1694: Documentation for Reliable event framework
---
.github/workflows/build-documentation.yml | 32 ++
.github/workflows/build-mariadb.yml | 25 +-
.github/workflows/build-mysql.yml | 25 +-
.github/workflows/build-postgresql.yml | 25 +-
fineract-avro-schemas/build.gradle | 2 +-
fineract-avro-schemas/src/main/avro/MessageV1.avsc | 5 -
.../src/main/avro/loan/v1/LoanAccountDataV1.avsc | 8 +
fineract-client/build.gradle | 2 +-
.../architecture/reliable-event-framework.adoc | 442 +++++++++++++++++++++
fineract-doc/src/docs/en/fineract-client.adoc | 6 +
.../en/images/reliable-event-framework-hla.png | Bin 0 -> 33122 bytes
fineract-doc/src/docs/en/index.adoc | 2 +-
.../loanaccount/data/LoanAccountData.java | 425 ++++++++++----------
.../service/LoanReadPlatformServiceImpl.java | 9 +-
14 files changed, 755 insertions(+), 253 deletions(-)
diff --git a/.github/workflows/build-documentation.yml
b/.github/workflows/build-documentation.yml
new file mode 100644
index 000000000..1cb74fa3f
--- /dev/null
+++ b/.github/workflows/build-documentation.yml
@@ -0,0 +1,32 @@
+name: Fineract Documentation build
+on: [push, pull_request]
+
+permissions:
+ contents: read
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout
+ uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b #
tag=v3
+ - name: Set up JDK 17
+ uses: actions/setup-java@2c7a4878f5d120bd643426d54ae1209b29cc01a3 #
tag=v3
+ with:
+ java-version: '17'
+ distribution: 'zulu'
+ cache: gradle
+ - uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 #
tag=v3
+ with:
+ node-version: 16
+ - name: Congfigure vega-cli
+ run: npm i -g vega-cli --unsafe
+ - name: Validate Gradle wrapper
+ uses:
gradle/wrapper-validation-action@e6e38bacfdf1a337459f332974bb2327a31aaf4b
+ - name: Install additional software
+ run: |
+ sudo apt-get update
+ sudo apt-get install ghostscript graphviz -y
+
+ - name: Documentation build
+ run: ./gradlew --no-daemon --console=plain doc
diff --git a/.github/workflows/build-mariadb.yml
b/.github/workflows/build-mariadb.yml
index c84dbefca..5c7b1b304 100644
--- a/.github/workflows/build-mariadb.yml
+++ b/.github/workflows/build-mariadb.yml
@@ -1,4 +1,4 @@
-name: Fineract Gradle build - MariaDB
+name: Fineract Build & Test - MariaDB
on: [push, pull_request]
permissions:
@@ -57,25 +57,28 @@ jobs:
sudo apt-get update
sudo apt-get install ghostscript graphviz -y
- - name: Basic Auth Build & Test
- run: ./gradlew --no-daemon --console=plain build test --fail-fast doc
-x :twofactor-tests:test -x :oauth2-test:test
-
- - name: 2FA Build & Test
- run: ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast
-
- - name: OAuth2 Build & Test
- run: ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast
+ - name: Build & Test
+ run: |
+ ./gradlew --no-daemon --console=plain build test --fail-fast -x
doc -x :twofactor-tests:test -x :oauth2-test:test
+ ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast
+ ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast
- name: Archive test results
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: test-results
- path: integration-tests/build/reports/
+ path: |
+ integration-tests/build/reports/
+ twofactor-tests/build/reports/
+ oauth2-tests/build/reports/
- name: Archive server logs
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: server-logs
- path: integration-tests/build/cargo/
+ path: |
+ integration-tests/build/cargo/
+ twofactor-tests/build/cargo/
+ oauth2-tests/build/cargo/
diff --git a/.github/workflows/build-mysql.yml
b/.github/workflows/build-mysql.yml
index d2fb2c6fa..337a76c69 100644
--- a/.github/workflows/build-mysql.yml
+++ b/.github/workflows/build-mysql.yml
@@ -1,4 +1,4 @@
-name: Fineract Gradle build - MySQL
+name: Fineract Build & Test - MySQL
on: [push, pull_request]
permissions:
@@ -57,25 +57,28 @@ jobs:
sudo apt-get update
sudo apt-get install ghostscript graphviz -y
- - name: Basic Auth Build & Test
- run: ./gradlew --no-daemon --console=plain build test --fail-fast doc
-x :twofactor-tests:test -x :oauth2-test:test -PdbType=mysql
-
- - name: 2FA Build & Test
- run: ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast -PdbType=mysql
-
- - name: OAuth2 Build & Test
- run: ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast -PdbType=mysql
+ - name: Build & Test
+ run: |
+ ./gradlew --no-daemon --console=plain build test --fail-fast -x
doc -x :twofactor-tests:test -x :oauth2-test:test -PdbType=mysql
+ ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast -PdbType=mysql
+ ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast -PdbType=mysql
- name: Archive test results
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: test-results
- path: integration-tests/build/reports/
+ path: |
+ integration-tests/build/reports/
+ twofactor-tests/build/reports/
+ oauth2-tests/build/reports/
- name: Archive server logs
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: server-logs
- path: integration-tests/build/cargo/
+ path: |
+ integration-tests/build/cargo/
+ twofactor-tests/build/cargo/
+ oauth2-tests/build/cargo/
diff --git a/.github/workflows/build-postgresql.yml
b/.github/workflows/build-postgresql.yml
index d09e68c04..efbf086b0 100644
--- a/.github/workflows/build-postgresql.yml
+++ b/.github/workflows/build-postgresql.yml
@@ -1,4 +1,4 @@
-name: Fineract Gradle build - PostgreSQL
+name: Fineract Build & Test - PostgreSQL
on: [push, pull_request]
permissions:
@@ -58,25 +58,28 @@ jobs:
sudo apt-get update
sudo apt-get install ghostscript graphviz -y
- - name: Basic Auth Build & Test
- run: ./gradlew --no-daemon --console=plain build test --fail-fast doc
-x :twofactor-tests:test -x :oauth2-test:test -PdbType=postgresql
-
- - name: 2FA Build & Test
- run: ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast -PdbType=postgresql
-
- - name: OAuth2 Build & Test
- run: ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast -PdbType=postgresql
+ - name: Build & Test
+ run: |
+ ./gradlew --no-daemon --console=plain build test --fail-fast -x
doc -x :twofactor-tests:test -x :oauth2-test:test -PdbType=postgresql
+ ./gradlew --no-daemon --console=plain :twofactor-tests:test
--fail-fast -PdbType=postgresql
+ ./gradlew --no-daemon --console=plain :oauth2-tests:test
--fail-fast -PdbType=postgresql
- name: Archive test results
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: test-results
- path: integration-tests/build/reports/
+ path: |
+ integration-tests/build/reports/
+ twofactor-tests/build/reports/
+ oauth2-tests/build/reports/
- name: Archive server logs
if: always()
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
# tag=v3
with:
name: server-logs
- path: integration-tests/build/cargo/
+ path: |
+ integration-tests/build/cargo/
+ twofactor-tests/build/cargo/
+ oauth2-tests/build/cargo/
diff --git a/fineract-avro-schemas/build.gradle
b/fineract-avro-schemas/build.gradle
index dd113de95..ebea32170 100644
--- a/fineract-avro-schemas/build.gradle
+++ b/fineract-avro-schemas/build.gradle
@@ -76,4 +76,4 @@ test {
sourceSets.main.java.srcDir new File(buildDir, "generated/java/src/main/java")
licenseFormatMain.dependsOn buildJavaSdk
-licenseMain.dependsOn buildJavaSdk
+licenseMain.dependsOn licenseFormatMain
diff --git a/fineract-avro-schemas/src/main/avro/MessageV1.avsc
b/fineract-avro-schemas/src/main/avro/MessageV1.avsc
index d20c5b626..df7679820 100644
--- a/fineract-avro-schemas/src/main/avro/MessageV1.avsc
+++ b/fineract-avro-schemas/src/main/avro/MessageV1.avsc
@@ -18,11 +18,6 @@
"doc": "The type of event the payload refers to. For example
LoanApprovedBusinessEvent",
"type": "string"
},
- {
- "name": "version",
- "doc": "The version of the type of event. For example 1, 2, 3,
etc",
- "type": "string"
- },
{
"name": "category",
"doc": "The category of event the payload refers to. For example
LOAN",
diff --git a/fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDataV1.avsc
b/fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDataV1.avsc
index 966c670bb..a7b13b941 100644
--- a/fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDataV1.avsc
+++ b/fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDataV1.avsc
@@ -75,6 +75,14 @@
"long"
]
},
+ {
+ "default": null,
+ "name": "clientExternalId",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
{
"default": null,
"name": "loanProductId",
diff --git a/fineract-client/build.gradle b/fineract-client/build.gradle
index cc6871c4a..c95507a4d 100644
--- a/fineract-client/build.gradle
+++ b/fineract-client/build.gradle
@@ -157,4 +157,4 @@ sourceSets.main.java.srcDir new File(buildDir,
"generated/java/src/main/java")
// NOTE: Gradle suggested these dependencies
licenseFormatMain.dependsOn buildJavaSdk
-licenseMain.dependsOn buildJavaSdk
+licenseMain.dependsOn licenseFormatMain
diff --git
a/fineract-doc/src/docs/en/chapters/architecture/reliable-event-framework.adoc
b/fineract-doc/src/docs/en/chapters/architecture/reliable-event-framework.adoc
new file mode 100644
index 000000000..5416b0f31
--- /dev/null
+++
b/fineract-doc/src/docs/en/chapters/architecture/reliable-event-framework.adoc
@@ -0,0 +1,442 @@
+= Reliable event framework
+
+Fineract is capable of generating and raising events for external consumers in
a reliable way. This section is going to describe all the details on that front
with examples.
+
+== Framework capabilities
+=== ACID (transactional) guarantee
+The event framework must support ACID guarantees on the business operation
level.
+
+Let’s see a simple use-case:
+
+1. A client applies to a loan on the UI
+2. The loan is created on the server
+3. A loan creation event is raised
+
+What happens if step 3 fails? Shall it fail the original loan creation process?
+
+What happens if step 2 fails but step 3 still gets executed? We’re raising an
event for a loan that hasn’t been created in reality.
+
+Therefore, raising an event is tied to the original business transaction to
ensure the data that’s getting written into the database along with the
respective events are saved in an all-or-nothing fashion.
+
+=== Messaging integration
+The system is able to send the raised events to downstream message channels.
The current implementation supports the following message channels:
+
+* ActiveMQ
+
+=== Ordering guarantee
+The events that are raised will be sent to the downstream message channels in
the same order as they were raised.
+
+=== Delivery guarantee
+The framework supports the at-least-once delivery guarantee for the raised
events.
+
+=== Reliability and fault-tolerance
+In terms of reliability and fault-tolerance, the event framework is able to
handle the cases when the downstream message channel is not able to accept
events. As soon as the message channel is back to operational, the events will
be sent again.
+
+=== Selective event producing
+Whether or not an event must be sent to downstream message channels for a
particular Fineract instance is configurable through the UI and API.
+
+=== Standardized format
+All the events sent to downstream message channels are conforming a
standardized format using Avro schemas.
+
+=== Extendability and customizations
+The event framework is capable of being easily extended with new events for
additional business operations or customizing existing events.
+
+=== Ability to send events in bulk
+The event framework makes it possible to sort of queue events until they are
ready to be sent and send them as a single message instead of sending each
event as a separate, individual one.
+
+For example during the COB process, there might be events raised in separate
business steps which needs to be sent out but they only need to be sent out at
the end of the COB execution process instead of one-by-one.
+
+== Architecture
+=== Intro
+On a high-level, the concept looks the following. An event gets raised in a
business operation. The event data gets saved to the database - to ensure ACID
guarantees. An asynchronous process takes the saved events from the database
and puts them onto a message channel.
+
+The flow can be seen in the following diagram:
+
+image::{imagesdir}/reliable-event-framework-hla.png[]
+
+=== Foundational business events
+The whole framework is built upon an existing infrastructure in Fineract; the
Business Events.
+
+As a quick recap, Business Events are Fineract events that can be raised at
any place in a business operation using the `BusinessEventNotifierService`.
Callbacks can be registered when a certain type of Business Event is raised and
other business operations can be done. For example when a Loan gets disbursed,
there's an interested party doing the Loan Arrears Aging recalculation using
the Business Event communication.
+
+The nice thing about the Business Events is that they are tied to the original
transaction which means if any of the processing on the subscriber's side fail,
the entire original transaction will be rolled back. This was one of the
requirements for the Reliable event framework.
+
+=== Event database integration
+The database plays a crucial part in the framework since to ensure
transactionality, - without doing proper transaction synchronization between
different message channels and the database - the framework is going to save
all the raised events into the same relational database that Fineract is using.
+
+==== Database structure
+The database structure looks the following
+
+[cols="1,1,1,1"]
+|===
+|*Name*
+|*Type*
+|*Description*
+|*Example*
+
+|`id`
+|number
+|Auto incremented ID.
+
+Not null.
+|`1`
+
+|`type`
+|text
+|The event type as a string.
+
+Not null.
+|`LoanApprovedBusinessEvent`
+
+|`schema`
+|text
+|The fully qualified name of the schema that was used for the data
serialization, as a string.
+
+Not null.
+|`org.apache.fineract.avro.loan.v1.LoanAccountDataV1`
+
+|`data`
+|BLOB (MySQL/MariaDB), BYTEA (PostgreSQL)
+|The event payload as Avro binary.
+
+Not null.
+|
+
+|`created_at`
+|timestamp
+|UTC timestamp when the event was raised.
+
+Not null.
+|`2022-09-06 14:20:10.148627 +00:00`
+
+|`status`
+|text
+|Enum text representing the status of the external event.
+
+Not null, indexed.
+|`TO_BE_SENT`, `SENT`
+
+|`sent_at`
+|timestamp
+|UTC timestamp when the event was sent.
+|`2022-09-06 14:30:10.148627 +00:00`
+
+|`idempotency_key`
+|text
+|Randomly generated UUID upon inserting a row into the table for idempotency
purposes.
+
+Not null.
+|`68aed085-8235-4722-b27d-b38674c19445`
+
+|`business_date`
+|date
+|The business date to when the event was generated.
+
+Not null, indexed.
+|`2022-09-05`
+|===
+
+The above database table contains the unsent events which later on will be
sent by an asynchronous event processor.
+
+Upon successfully sending an event, the corresponding statuses will be updated.
+
+=== Avro schemas
+For serializing events, Fineract is using Apache Avro. There are 2 reasons for
that:
+
+* More compact storage since Avro is a binary format
+* The Avro schemas are published with Fineract as a separate JAR so event
consumers can directly map the events into POJOs
+
+There are 3 different levels of Avro schemas used in Fineract for the Reliable
event framework which are described below.
+
+==== Standard event schema
+The standard event schema is for the regular events. These schemas are used
when saving a raised event into the database and using the Avro schema to
serialize the event data into a binary format.
+
+For example the OfficeDataV1 Avro schema looks the following:
+
+.`OfficeDataV1.avsc`
+[%collapsible]
+====
+[source,avroschema]
+----
+include::{rootdir}/fineract-avro-schemas/src/main/avro/office/v1/OfficeDataV1.avsc[]
+----
+====
+
+==== Event message schema
+The event message schema is just a wrapper around the standard event schema
with extra metadata for the event consumers.
+
+Since Avro is strongly typed, the event content needs to be first serialized
into a byte sequence and that needs to be wrapped around.
+
+This implies that for putting a single event message onto a message queue for
external consumption, data needs to be serialized 2 times; this is the 2-level
serialization.
+
+1. Serializing the event
+2. Serializing the already serialized event into an event message using the
message wrapper
+
+The message schema looks the following:
+
+.`MessageV1.avsc`
+[source,avroschema]
+----
+include::{rootdir}/fineract-avro-schemas/src/main/avro/MessageV1.avsc[]
+----
+
+==== Bulk event schema
+The bulk event schema is used when multiple events are supposed to be sent
together. This schema is used also when serializing the data for the database
storing but the idea is quite simple. Have an array of other event schemas
embedded into it.
+
+Since Avro is strongly typed, the array within the bulk event schema is an
array of `MessageV1` schemas. That way the consumers can decide which events
they want to deserialize and which don't.
+
+This elevates the regular 2-level serialization/deserialization concept up to
a 3-level one:
+
+1. Serializing the standard events
+2. Serializing the standard events into a bulk event
+3. Serializing the bulk event into an event message
+
+==== Versioning
+Avro is quite strict with changes to an existing schema and there are a number
of compatibility modes available.
+
+Fineract keeps it simple though. Version numbers - in the package names and in
the schema names - are increased with each published modification; meaning that
if the OfficeDataV1 schema needs a new field and the `OfficeDataV1` schema has
been published officially with Fineract, a new `OfficeDataV2` has to be created
with the new field instead of modifying the existing schema.
+
+This pattern ensures that a certain event is always deserialized with the
appropriate schema definition, otherwise the deserialization could fail.
+
+==== Code generation
+The Avro schemas are described as JSON documents. That's hardly usable
directly with Java hence Fineract generates Java POJOs from the Avro schemas.
The good thing about these POJOs is the fact that they can be
serialized/deserialized in themselves without any magic since they have a
`toByteBuffer` and `fromByteBuffer` method.
+
+From POJO to ByteBuffer:
+[source,java]
+----
+LoanAccountDataV1 avroDto = ...
+ByteBuffer buffer = avroDto.toByteBuffer();
+----
+
+From ByteBuffer to POJO:
+[source,java]
+----
+ByteBuffer buffer = ...
+LoanAccountDataV1 avroDto = LoanAccountDataV1.fromByteBuffer(buffer);
+----
+
+NOTE: The ByteBuffer is a stateful container and needs to be handled
carefully. Therefore Fineract has a built-in ByteBuffer to byte array
converter; `ByteBufferConverter`.
+
+==== Downstream event consumption
+When consuming events on the other side of the message channel, it's critical
to know which events the system is interested in. With the multi-level
serialization, it's possible to deserialize only parts of the message and
decide based on that whether it makes sense for a particular system to
deserialize the event payload more.
+
+Whether events are important can be decided based on:
+
+* the `type` attribute in the message
+* the `category` attribute in the message
+* the `dataschema` attribute in the message
+
+These are the main attributes in the message wrapper one can use to decide
whether an event message is useful.
+
+If the event needs to be deserialized, the next step is to find the
corresponding schema definition. That's going to be sent in the `dataschema`
attribute within the message wrapper. Since the attribute contains the
fully-qualified name of the respective schema, it can be easily resolved to a
Class object. Based on that class, the payload data can be easily deserialized
using the `fromByteBuffer` method on every generated schema POJO.
+
+=== Message ordering
+One of the requirements for the framework is to provide ordering guarantees.
All the events have to conform a happens-before relation.
+
+For the downstream consumers, this can be verified by the `id` attribute
within the messages. Since it's going to be a strictly-monotonic numeric
sequence, it can be used for ordering purposes.
+
+=== Event categorization
+For easier consumption, the terminology event category is introduced. This is
nothing else but the bounded context an event is related to.
+
+For example the LoanApprovedBusinessEvent and the
LoanWaiveInterestBusinessEvent are both related to the Loan bounded contexts.
+
+The category in which an event resides in is included in the message under the
`category` attribute.
+
+The existing event categories can be found under the <<event-categories>>
section.
+
+=== Asynchronous event processor
+The events stored in the database will be picked up and sent by a regularly
executed job.
+
+This job is a Fineract job, scheduled to run for every minute and will pick a
number of events in order. Those events will be put onto the downstream message
channel in the same order as they were raised.
+
+=== Purging events
+The events database table is going to grow continuously. That's why Fineract
has a purging functionality in place that's gonna delete old and already sent
events.
+
+It's implemented as a Fineract job and is disabled by default. It's called TBD.
+
+== Usage
+Using the event framework is quite simple. First, it has to be enabled through
properties or environment variable.
+
+The respective options are the following:
+
+* the `fineract.events.external.enabled` property
+* the `FINERACT_EXTERNAL_EVENTS_ENABLED` environment variable
+
+These configurations accept a boolean value; `true` or `false`.
+
+The key component to interact with is the
`BusinessEventNotifierService#notifyPostBusinessEvent` method.
+
+=== Raising events
+Raising events is really easy. An instance of a BusinessEvent interface is
needed, that's going to be the event. There are plenty of them available
already in the Fineract codebase.
+
+And that's pretty much it. Everything else is taken care of in terms of event
data persisting and later on putting it onto a message channel.
+
+An example of event raising:
+[source,java]
+----
+@Override
+public CommandProcessingResult createClient(final JsonCommand command) {
+ ...
+ businessEventNotifierService.notifyPostBusinessEvent(new
ClientCreateBusinessEvent(newClient));
+ ...
+ return ...;
+}
+----
+
+NOTE: The above code is copied from the
`ClientWritePlatformServiceJpaRepositoryImpl` class.
+
+==== Example event message content
+Since the message is serialized into binary format, it's hard to represent in
the documentation therefore here's a JSON representation of the data, just as
an example.
+[source,json]
+----
+{
+ "id": 121,
+ "source": "a65d759d-04f9-4ddf-ac52-34fa5d1f5a25",
+ "type": "LoanApprovedBusinessEvent",
+ "category": "Loan",
+ "createdAt": "2022-09-05T10:15:30",
+ "tenantId": "default",
+ "idempotencyKey": "abda146d-68b5-48ca-b527-16d2b7c5daef",
+ "dataschema": "org.apache.fineract.avro.loan.v1.LoanAccountDataV1",
+ "data": "..."
+}
+----
+
+NOTE: The source attribute refers to an ID that's identifying the producer
service. Fineract will regenerate this ID upon each application startup.
+
+=== Raising bulk events
+Raising bulk events is really easy as well. The 2 key methods are:
+
+* `BusinessEventNotifierService#startExternalEventRecording`
+* `BusinessEventNotifierService#stopExternalEventRecording`
+
+First, you have to start recording your events. This recording will be applied
for the current thread. And then you can raise as many events as you want with
the regular `BusinessEventNotifierService#notifyPostBusinessEvent` method, but
they won't get saved to the database immediately. They'll get "recorded" into
an internal buffer.
+
+When you stop recording using the method above, all the recorded events will
be saved as a bulk event to the database; and serialized appropriately.
+
+From then on, the bulk event works just like any of the event. It'll be picked
up by the processor to send it to a message channel.
+
+=== Event categories [[event-categories]]
+TBD
+
+=== Selective event producing
+TBD
+
+== Customizations
+The framework provides a number of customization options:
+
+* Creating new events (that's already given by the Business Events)
+* Creating new Avro schemas
+* Customizing what data gets serialized for existing events
+
+In the upcoming sections, that's what going to be discussed.
+
+=== Creating new events
+Creating new events is super easy. Just create an implementation of the
`BusinessEvent` interface and that's it.
+
+From then on, you can raise those events in the system, although you can't
publish them to an external message channel. If you have the event framework
enabled, it's going to fail with not finding the appropriate serializer for
your business event.
+
+NOTE: There are existing serializers which might be able to handle your new
event. For example the `LoanBusinessEventSerializer` is capable of handling all
`LoanBusinessEvent` subclasses so there's no need to create a brand new
serializer.
+
+The interface looks the following:
+
+.`BusinessEvent.java`
+[source,java]
+----
+include::{rootdir}/fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/business/domain/BusinessEvent.java[lines=21..]
+----
+
+Quite simple. The `get` method should return the data you want to pass within
the event instance. The `getType` method returns the name of the business event
that's gonna be saved as the `type` into the database.
+
+NOTE: Creating a new business event only means that it can be used for raising
an event. To make it compatible with the event framework and to be sent to a
message channel, some extra work is needed which are described below.
+
+=== Creating new Avro schemas and serializers
+First let's talk about the event serializers because that's what's needed to
make a new event compatible with the framework.
+
+The serializer has a special interface, `BusinessEventSerializer`.
+
+.`BusinessEventSerializer.java`
+[source,java]
+----
+include::{rootdir}/fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/BusinessEventSerializer.java[lines=25..]
+----
+
+An implementation of this interface shall be registered as a Spring bean, and
it'll be picked up automatically by the framework.
+
+NOTE: You can look at the existing serializers for implementation ideas.
+
+New Avro schemas can be easily created. Just create a new Avro schema file in
the `fineract-avro-schemas` project under the respective bounded context
folder, and it will be picked up automatically by the code generator.
+
+=== BigDecimal support in Avro schemas
+Apache Avro by default doesn't support complex types like a BigDecimal. It has
to be implemented using a custom snippet like this:
+
+[source,avroschema]
+----
+include::{rootdir}/fineract-avro-schemas/src/main/resources/avro-templates/bigdecimal.avsc[]
+----
+
+It's a 20 precision and 8 scale BigDecimal.
+
+Obviously it's quite challenging to copy-paste this snippet to every single
BigDecimal field, so there's a customization in place for Fineract.
+The type `bigdecimal` is supported natively, and you're free to use it like
this:
+
+[source,avroschema]
+----
+{
+ "default": null,
+ "name": "principal",
+ "type": [
+ "null",
+ "bigdecimal"
+ ]
+}
+----
+
+NOTE: This `bigdecimal` type will be simple replaced with the BigDecimal
snippet showed above during the compilation process.
+
+=== Custom data serialization for existing events
+In case there's a need some extra bit of information within the event message
that the default serializers are not providing, you can override this behavior
by registering a brand-new custom serializer (as shown above).
+
+Since there's a priority order of serializers, the only thing the custom
serializer need to do is to be annotated by the `@Order` annotation or to
implement the `Ordered` interface.
+
+An example custom serializer with priority looks the following:
+[source,java]
+----
+@Component
+@RequiredArgsConstructor
+@Order(Ordered.HIGHEST_PRECEDENCE)
+public class CustomLoanBusinessEventSerializer implements
BusinessEventSerializer {
+ ...
+
+ @Override
+ public <T> boolean canSerialize(BusinessEvent<T> event) {
+ return ...;
+ }
+
+ @Override
+ public <T> byte[] serialize(BusinessEvent<T> rawEvent) throws IOException {
+ ...
+ ByteBuffer buffer = avroDto.toByteBuffer();
+ return byteBufferConverter.convert(buffer);
+ }
+
+ @Override
+ public Class<? extends GenericContainer> getSupportedSchema() {
+ return ...;
+ }
+}
+----
+
+NOTE: All the default serializers are having `Ordered.LOWEST_PRECEDENCE`.
+
+== Appendix A: Properties and environment variables
+[cols="1,1,1,1"]
+|===
+|Property name |Environment variable |Default value |Description
+
+|`fineract.events.external.enabled`
+|`FINERACT_EXTERNAL_EVENTS_ENABLED`
+|`false`
+|Whether the external event sending is enabled or disabled.
+
+|===
\ No newline at end of file
diff --git a/fineract-doc/src/docs/en/fineract-client.adoc
b/fineract-doc/src/docs/en/fineract-client.adoc
new file mode 100644
index 000000000..31a615164
--- /dev/null
+++ b/fineract-doc/src/docs/en/fineract-client.adoc
@@ -0,0 +1,6 @@
+= Fineract Client Documentation
+
+[%collapsible]
+====
+include::{rootdir}/fineract-client/build/generated/asciidoc/index.adoc[]
+====
\ No newline at end of file
diff --git a/fineract-doc/src/docs/en/images/reliable-event-framework-hla.png
b/fineract-doc/src/docs/en/images/reliable-event-framework-hla.png
new file mode 100644
index 000000000..faad90bef
Binary files /dev/null and
b/fineract-doc/src/docs/en/images/reliable-event-framework-hla.png differ
diff --git a/fineract-doc/src/docs/en/index.adoc
b/fineract-doc/src/docs/en/index.adoc
index c68bd3dd3..3cb04b341 100644
--- a/fineract-doc/src/docs/en/index.adoc
+++ b/fineract-doc/src/docs/en/index.adoc
@@ -47,7 +47,7 @@ include::chapters/release/index.adoc[leveloffset=+1]
include::chapters/sdk/index.adoc[leveloffset=+1]
-include::{rootdir}/fineract-client/build/generated/asciidoc/index.adoc[leveloffset=+1]
+include::fineract-client.adoc[leveloffset=+1]
include::faq.adoc[leveloffset=+1]
diff --git
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java
index 79cc3e1b6..0d59d9f37 100644
---
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java
+++
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java
@@ -76,6 +76,7 @@ public final class LoanAccountData {
private final Long clientId;
private final String clientAccountNo;
private final String clientName;
+ private final String clientExternalId;
private final Long clientOfficeId;
private final GroupGeneralData group;
private final Long loanProductId;
@@ -328,6 +329,7 @@ public final class LoanAccountData {
this.clientAccountNo = null;
this.clientName = null;
this.clientOfficeId = null;
+ this.clientExternalId = null;
this.group = null;
this.loanProductId = null;
this.loanProductName = null;
@@ -455,6 +457,7 @@ public final class LoanAccountData {
final String clientName = null;
final String clientAccountNo = null;
final Long clientOfficeId = null;
+ final String clientExternalId = null;
final GroupGeneralData group = null;
final EnumOptionData loanType = null;
final Long loanProductId = null;
@@ -566,34 +569,34 @@ public final class LoanAccountData {
final CollectionData delinquent = CollectionData.template();
final DelinquencyRangeData delinquencyRange = null;
- return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId, group,
- loanType, loanProductId, loanProductName,
loanProductDescription, isLoanProductLinkedToFloatingRate, fundId, fundName,
- loanPurposeId, loanPurposeName, loanOfficerId,
loanOfficerName, currencyData, proposedPrincipal, principal, principal,
- netDisbursalAmount, totalOverpaid, inArrearsTolerance,
termFrequency, termPeriodFrequencyType, numberOfRepayments,
- repaymentEvery, repaymentFrequencyType,
repaymentFrequencyNthDayType, repaymentFrequencyDayOfWeekType,
- transactionProcessingStrategyId,
transactionProcessingStrategyName, amortizationType, interestRatePerPeriod,
- interestRateFrequencyType, annualInterestRate, interestType,
isFloatingInterestRate, interestRateDifferential,
- interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion, expectedFirstRepaymentOnDate,
graceOnPrincipalPayment,
- recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
graceOnInterestCharged, interestChargedFromDate, timeline,
- summary, feeChargesDueAtDisbursementCharged,
repaymentSchedule, transactions, charges, collateral, guarantors, calendarData,
- productOptions, termFrequencyTypeOptions,
repaymentFrequencyTypeOptions, repaymentFrequencyNthDayTypeOptions,
- repaymentFrequencyDayOfWeekTypeOptions,
transactionProcessingStrategyOptions, interestRateFrequencyTypeOptions,
- amortizationTypeOptions, interestTypeOptions,
interestCalculationPeriodTypeOptions, fundOptions, chargeOptions,
- chargeTemplate, loanOfficerOptions, loanPurposeOptions,
loanCollateralOptions, calendarOptions, syncDisbursementWithMeeting,
- loancounter, loanProductCounter, notes, accountLinkingOptions,
linkedAccount, disbursementData, multiDisburseLoan,
- canDefineInstallmentAmount, fixedEmiAmount,
maxOutstandingLoanBalance, emiAmountVariations, memberVariations, product,
- inArrears, graceOnArrearsAgeing, overdueCharges, isNPA,
daysInMonthType, daysInYearType, isInterestRecalculationEnabled,
- interestRecalculationData, originalSchedule,
createStandingInstructionAtDisbursement, paidInAdvance, interestRatesPeriods,
- isVariableInstallmentsAllowed, minimumGap, maximumGap,
subStatus, canUseForTopup, clientActiveLoanOptions, isTopup,
- closureLoanId, closureLoanAccountNo, topupAmount,
isEqualAmortization, rates, isRatesEnabled,
- fixedPrincipalPercentagePerInstallment, delinquent,
delinquencyRange);
+ return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId,
+ clientExternalId, group, loanType, loanProductId,
loanProductName, loanProductDescription,
+ isLoanProductLinkedToFloatingRate, fundId, fundName,
loanPurposeId, loanPurposeName, loanOfficerId, loanOfficerName,
+ currencyData, proposedPrincipal, principal, principal,
netDisbursalAmount, totalOverpaid, inArrearsTolerance, termFrequency,
+ termPeriodFrequencyType, numberOfRepayments, repaymentEvery,
repaymentFrequencyType, repaymentFrequencyNthDayType,
+ repaymentFrequencyDayOfWeekType,
transactionProcessingStrategyId, transactionProcessingStrategyName,
amortizationType,
+ interestRatePerPeriod, interestRateFrequencyType,
annualInterestRate, interestType, isFloatingInterestRate,
+ interestRateDifferential, interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion,
+ expectedFirstRepaymentOnDate, graceOnPrincipalPayment,
recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
+ graceOnInterestCharged, interestChargedFromDate, timeline,
summary, feeChargesDueAtDisbursementCharged, repaymentSchedule,
+ transactions, charges, collateral, guarantors, calendarData,
productOptions, termFrequencyTypeOptions,
+ repaymentFrequencyTypeOptions,
repaymentFrequencyNthDayTypeOptions, repaymentFrequencyDayOfWeekTypeOptions,
+ transactionProcessingStrategyOptions,
interestRateFrequencyTypeOptions, amortizationTypeOptions, interestTypeOptions,
+ interestCalculationPeriodTypeOptions, fundOptions,
chargeOptions, chargeTemplate, loanOfficerOptions, loanPurposeOptions,
+ loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loancounter, loanProductCounter, notes,
+ accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount, fixedEmiAmount,
+ maxOutstandingLoanBalance, emiAmountVariations,
memberVariations, product, inArrears, graceOnArrearsAgeing, overdueCharges,
+ isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData, originalSchedule,
+ createStandingInstructionAtDisbursement, paidInAdvance,
interestRatesPeriods, isVariableInstallmentsAllowed, minimumGap,
+ maximumGap, subStatus, canUseForTopup,
clientActiveLoanOptions, isTopup, closureLoanId, closureLoanAccountNo,
topupAmount,
+ isEqualAmortization, rates, isRatesEnabled,
fixedPrincipalPercentagePerInstallment, delinquent, delinquencyRange);
}
/**
* Used to produce a {@link LoanAccountData} with only client information
defaulted.
*/
public static LoanAccountData clientDefaults(final Long clientId, final
String clientAccountNo, final String clientName,
- final Long clientOfficeId, final LocalDate
expectedDisbursementDate) {
+ final Long clientOfficeId, final String clientExternalId, final
LocalDate expectedDisbursementDate) {
final Long id = null;
final String accountNo = null;
final LoanStatusEnumData status = null;
@@ -713,36 +716,36 @@ public final class LoanAccountData {
final CollectionData delinquent = CollectionData.template();
final DelinquencyRangeData delinquencyRange = null;
- return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId, group,
- loanType, loanProductId, loanProductName,
loanProductDescription, isLoanProductLinkedToFloatingRate, fundId, fundName,
- loanPurposeId, loanPurposeName, loanOfficerId,
loanOfficerName, currencyData, proposedPrincipal, principal, principal,
- netDisbursalAmount, totalOverpaid, inArrearsTolerance,
termFrequency, termPeriodFrequencyType, numberOfRepayments,
- repaymentEvery, repaymentFrequencyType,
repaymentFrequencyNthDayType, repaymentFrequencyDayOfWeekType,
- transactionProcessingStrategyId,
transactionProcessingStrategyName, amortizationType, interestRatePerPeriod,
- interestRateFrequencyType, annualInterestRate, interestType,
isFloatingInterestRate, interestRateDifferential,
- interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion, expectedFirstRepaymentOnDate,
graceOnPrincipalPayment,
- recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
graceOnInterestCharged, interestChargedFromDate, timeline,
- summary, feeChargesDueAtDisbursementCharged,
repaymentSchedule, transactions, charges, collateral, guarantors, calendarData,
- productOptions, termFrequencyTypeOptions,
repaymentFrequencyTypeOptions, repaymentFrequencyNthDayTypeOptions,
- repaymentFrequencyDayOfWeekTypeOptions,
repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions,
- interestTypeOptions, interestCalculationPeriodTypeOptions,
fundOptions, chargeOptions, chargeTemplate, loanOfficerOptions,
- loanPurposeOptions, loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loancounter, loanProductCounter,
- notes, accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount,
- fixedEmiAmount, maxOutstandingLoanBalance,
emiAmountVariations, memberVariations, product, inArrears, graceOnArrearsAgeing,
- overdueCharges, isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData,
- originalSchedule, createStandingInstructionAtDisbursement,
paidInAdvance, interestRatesPeriods,
- isVariableInstallmentsAllowed, minimumGap, maximumGap,
subStatus, canUseForTopup, clientActiveLoanOptions, isTopup,
- closureLoanId, closureLoanAccountNo, topupAmount,
isEqualAmortization, rates, isRatesEnabled,
- fixedPrincipalPercentagePerInstallment, delinquent,
delinquencyRange);
+ return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId,
+ clientExternalId, group, loanType, loanProductId,
loanProductName, loanProductDescription,
+ isLoanProductLinkedToFloatingRate, fundId, fundName,
loanPurposeId, loanPurposeName, loanOfficerId, loanOfficerName,
+ currencyData, proposedPrincipal, principal, principal,
netDisbursalAmount, totalOverpaid, inArrearsTolerance, termFrequency,
+ termPeriodFrequencyType, numberOfRepayments, repaymentEvery,
repaymentFrequencyType, repaymentFrequencyNthDayType,
+ repaymentFrequencyDayOfWeekType,
transactionProcessingStrategyId, transactionProcessingStrategyName,
amortizationType,
+ interestRatePerPeriod, interestRateFrequencyType,
annualInterestRate, interestType, isFloatingInterestRate,
+ interestRateDifferential, interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion,
+ expectedFirstRepaymentOnDate, graceOnPrincipalPayment,
recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
+ graceOnInterestCharged, interestChargedFromDate, timeline,
summary, feeChargesDueAtDisbursementCharged, repaymentSchedule,
+ transactions, charges, collateral, guarantors, calendarData,
productOptions, termFrequencyTypeOptions,
+ repaymentFrequencyTypeOptions,
repaymentFrequencyNthDayTypeOptions, repaymentFrequencyDayOfWeekTypeOptions,
+ repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions, interestTypeOptions,
+ interestCalculationPeriodTypeOptions, fundOptions,
chargeOptions, chargeTemplate, loanOfficerOptions, loanPurposeOptions,
+ loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loancounter, loanProductCounter, notes,
+ accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount, fixedEmiAmount,
+ maxOutstandingLoanBalance, emiAmountVariations,
memberVariations, product, inArrears, graceOnArrearsAgeing, overdueCharges,
+ isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData, originalSchedule,
+ createStandingInstructionAtDisbursement, paidInAdvance,
interestRatesPeriods, isVariableInstallmentsAllowed, minimumGap,
+ maximumGap, subStatus, canUseForTopup,
clientActiveLoanOptions, isTopup, closureLoanId, closureLoanAccountNo,
topupAmount,
+ isEqualAmortization, rates, isRatesEnabled,
fixedPrincipalPercentagePerInstallment, delinquent, delinquencyRange);
}
public static LoanAccountData populateClientDefaults(final LoanAccountData
acc, final LoanAccountData clientAcc) {
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, clientAcc.clientId, clientAcc.clientAccountNo,
- clientAcc.clientName, clientAcc.clientOfficeId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
- acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
- acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
- acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ clientAcc.clientName, clientAcc.clientOfficeId,
acc.clientExternalId, acc.group, acc.loanType, acc.loanProductId,
+ acc.loanProductName, acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
+ acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
+ acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
@@ -781,6 +784,7 @@ public final class LoanAccountData {
final String clientAccountNo = null;
final String clientName = null;
final Long clientOfficeId = null;
+ final String clientExternalId = null;
final EnumOptionData loanType = null;
final Long loanProductId = null;
final String loanProductName = null;
@@ -893,42 +897,43 @@ public final class LoanAccountData {
final CollectionData delinquent = CollectionData.template();
final DelinquencyRangeData delinquencyRange = null;
- return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId, group,
- loanType, loanProductId, loanProductName,
loanProductDescription, isLoanProductLinkedToFloatingRate, fundId, fundName,
- loanPurposeId, loanPurposeName, loanOfficerId,
loanOfficerName, currencyData, proposedPrincipal, principal, principal,
- netDisbursalAmount, totalOverpaid, inArrearsTolerance,
termFrequency, termPeriodFrequencyType, numberOfRepayments,
- repaymentEvery, repaymentFrequencyType,
repaymentFrequencyNthDayType, repaymentFrequencyDayOfWeekType,
- transactionProcessingStrategyId,
transactionProcessingStrategyName, amortizationType, interestRatePerPeriod,
- interestRateFrequencyType, annualInterestRate, interestType,
isFloatingInterestRate, interestRateDifferential,
- interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion, expectedFirstRepaymentOnDate,
graceOnPrincipalPayment,
- recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
graceOnInterestCharged, interestChargedFromDate, timeline,
- summary, feeChargesDueAtDisbursementCharged,
repaymentSchedule, transactions, charges, collateral, guarantors, calendarData,
- productOptions, termFrequencyTypeOptions,
repaymentFrequencyTypeOptions, repaymentFrequencyNthDayTypeOptions,
- repaymentFrequencyDayOfWeekTypeOptions,
repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions,
- interestTypeOptions, interestCalculationPeriodTypeOptions,
fundOptions, chargeOptions, chargeTemplate, loanOfficerOptions,
- loanPurposeOptions, loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loancounter, loanProductCounter,
- notes, accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount,
- fixedEmiAmount, maxOutstandingBalance, emiAmountVariations,
memberVariations, product, inArrears, graceOnArrearsAgeing,
- overdueCharges, isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData,
- originalSchedule, createStandingInstructionAtDisbursement,
paidInAdvance, interestRatesPeriods,
- isVariableInstallmentsAllowed, minimumGap, maximumGap,
subStatus, canUseForTopup, clientActiveLoanOptions, isTopup,
- closureLoanId, closureLoanAccountNo, topupAmount,
isEqualAmortization, rates, isRatesEnabled,
- fixedPrincipalPercentagePerInstallment, delinquent,
delinquencyRange);
+ return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId,
+ clientExternalId, group, loanType, loanProductId,
loanProductName, loanProductDescription,
+ isLoanProductLinkedToFloatingRate, fundId, fundName,
loanPurposeId, loanPurposeName, loanOfficerId, loanOfficerName,
+ currencyData, proposedPrincipal, principal, principal,
netDisbursalAmount, totalOverpaid, inArrearsTolerance, termFrequency,
+ termPeriodFrequencyType, numberOfRepayments, repaymentEvery,
repaymentFrequencyType, repaymentFrequencyNthDayType,
+ repaymentFrequencyDayOfWeekType,
transactionProcessingStrategyId, transactionProcessingStrategyName,
amortizationType,
+ interestRatePerPeriod, interestRateFrequencyType,
annualInterestRate, interestType, isFloatingInterestRate,
+ interestRateDifferential, interestCalculationPeriodType,
allowPartialPeriodInterestCalcualtion,
+ expectedFirstRepaymentOnDate, graceOnPrincipalPayment,
recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
+ graceOnInterestCharged, interestChargedFromDate, timeline,
summary, feeChargesDueAtDisbursementCharged, repaymentSchedule,
+ transactions, charges, collateral, guarantors, calendarData,
productOptions, termFrequencyTypeOptions,
+ repaymentFrequencyTypeOptions,
repaymentFrequencyNthDayTypeOptions, repaymentFrequencyDayOfWeekTypeOptions,
+ repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions, interestTypeOptions,
+ interestCalculationPeriodTypeOptions, fundOptions,
chargeOptions, chargeTemplate, loanOfficerOptions, loanPurposeOptions,
+ loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loancounter, loanProductCounter, notes,
+ accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount, fixedEmiAmount,
+ maxOutstandingBalance, emiAmountVariations, memberVariations,
product, inArrears, graceOnArrearsAgeing, overdueCharges,
+ isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData, originalSchedule,
+ createStandingInstructionAtDisbursement, paidInAdvance,
interestRatesPeriods, isVariableInstallmentsAllowed, minimumGap,
+ maximumGap, subStatus, canUseForTopup,
clientActiveLoanOptions, isTopup, closureLoanId, closureLoanAccountNo,
topupAmount,
+ isEqualAmortization, rates, isRatesEnabled,
fixedPrincipalPercentagePerInstallment, delinquent, delinquencyRange);
}
public static LoanAccountData populateGroupDefaults(final LoanAccountData
acc, final LoanAccountData groupAcc) {
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, groupAcc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, groupAcc.timeline, acc.summary,
+ acc.clientOfficeId, acc.clientExternalId, groupAcc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
groupAcc.timeline, acc.summary,
acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
@@ -966,6 +971,7 @@ public final class LoanAccountData {
final String clientAccountNo = null;
final String clientName = null;
final Long clientOfficeId = null;
+ final String clientExternalId = null;
final GroupGeneralData group = null;
final EnumOptionData loanType = null;
final String groupName = null;
@@ -1087,12 +1093,12 @@ public final class LoanAccountData {
final CollectionData delinquent = CollectionData.template();
final DelinquencyRangeData delinquencyRange = null;
- return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId, group,
- loanType, product.getId(), product.getName(),
product.getDescription(), product.isLinkedToFloatingInterestRates(),
- product.getFundId(), product.getFundName(), loanPurposeId,
loanPurposeName, loanOfficerId, loanOfficerName,
- product.getCurrency(), proposedPrincipal, principal,
principal, netDisbursalAmount, totalOverpaid,
- product.getInArrearsTolerance(), termFrequency,
termPeriodFrequencyType, numberOfRepayments, product.getRepaymentEvery(),
- product.getRepaymentFrequencyType(), null, null,
product.getTransactionProcessingStrategyId(),
+ return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId,
+ clientExternalId, group, loanType, product.getId(),
product.getName(), product.getDescription(),
+ product.isLinkedToFloatingInterestRates(),
product.getFundId(), product.getFundName(), loanPurposeId, loanPurposeName,
+ loanOfficerId, loanOfficerName, product.getCurrency(),
proposedPrincipal, principal, principal, netDisbursalAmount,
+ totalOverpaid, product.getInArrearsTolerance(), termFrequency,
termPeriodFrequencyType, numberOfRepayments,
+ product.getRepaymentEvery(),
product.getRepaymentFrequencyType(), null, null,
product.getTransactionProcessingStrategyId(),
transactionProcessingStrategyName,
product.getAmortizationType(), interestRatePerPeriod,
product.getInterestRateFrequencyType(),
product.getAnnualInterestRate(), product.getInterestType(),
product.isFloatingInterestRateCalculationAllowed(),
product.getDefaultDifferentialLendingRate(),
@@ -1158,12 +1164,12 @@ public final class LoanAccountData {
final DelinquencyRangeData delinquencyRange = null;
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType, product.getId(),
product.getName(), product.getDescription(),
- product.isLinkedToFloatingInterestRates(),
product.getFundId(), product.getFundName(), acc.loanPurposeId,
- acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
product.getCurrency(), product.getPrincipal(),
- product.getPrincipal(), product.getPrincipal(),
netDisbursalAmount, acc.totalOverpaid, product.getInArrearsTolerance(),
- termFrequency, termPeriodFrequencyType,
product.getNumberOfRepayments(), product.getRepaymentEvery(),
- product.getRepaymentFrequencyType(), null, null,
product.getTransactionProcessingStrategyId(),
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, product.getId(), product.getName(),
+ product.getDescription(),
product.isLinkedToFloatingInterestRates(), product.getFundId(),
product.getFundName(),
+ acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
acc.loanOfficerName, product.getCurrency(),
+ product.getPrincipal(), product.getPrincipal(),
product.getPrincipal(), netDisbursalAmount, acc.totalOverpaid,
+ product.getInArrearsTolerance(), termFrequency,
termPeriodFrequencyType, product.getNumberOfRepayments(),
+ product.getRepaymentEvery(),
product.getRepaymentFrequencyType(), null, null,
product.getTransactionProcessingStrategyId(),
product.getTransactionProcessingStrategyName(),
product.getAmortizationType(), product.getInterestRatePerPeriod(),
product.getInterestRateFrequencyType(),
product.getAnnualInterestRate(), product.getInterestType(),
product.isFloatingInterestRateCalculationAllowed(),
product.getDefaultDifferentialLendingRate(),
@@ -1191,10 +1197,10 @@ public final class LoanAccountData {
*/
public static LoanAccountData basicLoanDetails(final Long id, final String
accountNo, final LoanStatusEnumData status,
final String externalId, final Long clientId, final String
clientAccountNo, final String clientName, final Long clientOfficeId,
- final GroupGeneralData group, final EnumOptionData loanType, final
Long loanProductId, final String loanProductName,
- final String loanProductDescription, final boolean
isLoanProductLinkedToFloatingRate, final Long fundId, final String fundName,
- final Long loanPurposeId, final String loanPurposeName, final Long
loanOfficerId, final String loanOfficerName,
- final CurrencyData currencyData, final BigDecimal
proposedPrincipal, final BigDecimal principal,
+ final String clientExternalId, final GroupGeneralData group, final
EnumOptionData loanType, final Long loanProductId,
+ final String loanProductName, final String loanProductDescription,
final boolean isLoanProductLinkedToFloatingRate,
+ final Long fundId, final String fundName, final Long
loanPurposeId, final String loanPurposeName, final Long loanOfficerId,
+ final String loanOfficerName, final CurrencyData currencyData,
final BigDecimal proposedPrincipal, final BigDecimal principal,
final BigDecimal approvedPrincipal, final BigDecimal
netDisbursalAmount, final BigDecimal totalOverpaid,
final BigDecimal inArrearsTolerance, final Integer termFrequency,
final EnumOptionData termPeriodFrequencyType,
final Integer numberOfRepayments, final Integer repaymentEvery,
final EnumOptionData repaymentFrequencyType,
@@ -1256,21 +1262,22 @@ public final class LoanAccountData {
final Boolean isRatesEnabled = false;
final CollectionData delinquent = CollectionData.template();
- return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId, group,
- loanType, loanProductId, loanProductName,
loanProductDescription, isLoanProductLinkedToFloatingRate, fundId, fundName,
- loanPurposeId, loanPurposeName, loanOfficerId,
loanOfficerName, currencyData, proposedPrincipal, principal,
- approvedPrincipal, netDisbursalAmount, totalOverpaid,
inArrearsTolerance, termFrequency, termPeriodFrequencyType,
- numberOfRepayments, repaymentEvery, repaymentFrequencyType,
repaymentFrequencyNthDayType, repaymentFrequencyDayOfWeekType,
- transactionStrategyId, transactionStrategyName,
amortizationType, interestRatePerPeriod, interestRateFrequencyType,
- annualInterestRate, interestType, isFloatingInterestRate,
interestRateDifferential, interestCalculationPeriodType,
- allowPartialPeriodInterestCalcualtion,
expectedFirstRepaymentOnDate, graceOnPrincipalPayment,
- recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
graceOnInterestCharged, interestChargedFromDate, timeline,
- loanSummary, feeChargesDueAtDisbursementCharged,
repaymentSchedule, transactions, charges, collateral, guarantors,
- calendarData, productOptions, termFrequencyTypeOptions,
repaymentFrequencyTypeOptions, repaymentFrequencyNthDayTypeOptions,
- repaymentFrequencyDayOfWeekTypeOptions,
repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions,
- interestTypeOptions, interestCalculationPeriodTypeOptions,
fundOptions, chargeOptions, chargeTemplate, loanOfficerOptions,
- loanPurposeOptions, loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loanCounter, loanProductCounter,
- notes, accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount, fixedEmiAmont,
+ return new LoanAccountData(id, accountNo, status, externalId,
clientId, clientAccountNo, clientName, clientOfficeId,
+ clientExternalId, group, loanType, loanProductId,
loanProductName, loanProductDescription,
+ isLoanProductLinkedToFloatingRate, fundId, fundName,
loanPurposeId, loanPurposeName, loanOfficerId, loanOfficerName,
+ currencyData, proposedPrincipal, principal, approvedPrincipal,
netDisbursalAmount, totalOverpaid, inArrearsTolerance,
+ termFrequency, termPeriodFrequencyType, numberOfRepayments,
repaymentEvery, repaymentFrequencyType,
+ repaymentFrequencyNthDayType, repaymentFrequencyDayOfWeekType,
transactionStrategyId, transactionStrategyName,
+ amortizationType, interestRatePerPeriod,
interestRateFrequencyType, annualInterestRate, interestType,
+ isFloatingInterestRate, interestRateDifferential,
interestCalculationPeriodType, allowPartialPeriodInterestCalcualtion,
+ expectedFirstRepaymentOnDate, graceOnPrincipalPayment,
recurringMoratoriumOnPrincipalPeriods, graceOnInterestPayment,
+ graceOnInterestCharged, interestChargedFromDate, timeline,
loanSummary, feeChargesDueAtDisbursementCharged,
+ repaymentSchedule, transactions, charges, collateral,
guarantors, calendarData, productOptions, termFrequencyTypeOptions,
+ repaymentFrequencyTypeOptions,
repaymentFrequencyNthDayTypeOptions, repaymentFrequencyDayOfWeekTypeOptions,
+ repaymentStrategyOptions, interestRateFrequencyTypeOptions,
amortizationTypeOptions, interestTypeOptions,
+ interestCalculationPeriodTypeOptions, fundOptions,
chargeOptions, chargeTemplate, loanOfficerOptions, loanPurposeOptions,
+ loanCollateralOptions, calendarOptions,
syncDisbursementWithMeeting, loanCounter, loanProductCounter, notes,
+ accountLinkingOptions, linkedAccount, disbursementData,
multiDisburseLoan, canDefineInstallmentAmount, fixedEmiAmont,
outstandingLoanBalance, emiAmountVariations, memberVariations,
product, inArrears, graceOnArrearsAgeing, overdueCharges,
isNPA, daysInMonthType, daysInYearType,
isInterestRecalculationEnabled, interestRecalculationData, originalSchedule,
createStandingInstructionAtDisbursement, paidInAdvance,
interestRatesPeriods, isVariableInstallmentsAllowed, minimumGap,
@@ -1306,24 +1313,24 @@ public final class LoanAccountData {
}
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, repaymentSchedule,
transactions, charges, collateral, guarantors, calendarData,
- productOptions, termFrequencyTypeOptions,
repaymentFrequencyTypeOptions, repaymentFrequencyNthDayTypeOptions,
- repaymentFrequencyDayOfWeekTypeOptions,
transactionProcessingStrategyOptions, interestRateFrequencyTypeOptions,
- amortizationTypeOptions, interestTypeOptions,
interestCalculationPeriodTypeOptions, fundOptions, chargeOptions,
- chargeTemplate, loanOfficerOptions, loanPurposeOptions,
loanCollateralOptions, calendarOptions,
- acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, notes, accountLinkingOptions, linkedAccount,
- disbursementDetails, acc.multiDisburseLoan,
acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
- acc.maxOutstandingLoanBalance, emiAmountVariations,
acc.memberVariations, acc.product, acc.inArrears,
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ repaymentSchedule, transactions, charges, collateral,
guarantors, calendarData, productOptions, termFrequencyTypeOptions,
+ repaymentFrequencyTypeOptions,
repaymentFrequencyNthDayTypeOptions, repaymentFrequencyDayOfWeekTypeOptions,
+ transactionProcessingStrategyOptions,
interestRateFrequencyTypeOptions, amortizationTypeOptions, interestTypeOptions,
+ interestCalculationPeriodTypeOptions, fundOptions,
chargeOptions, chargeTemplate, loanOfficerOptions, loanPurposeOptions,
+ loanCollateralOptions, calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter, acc.loanProductCounter, notes,
+ accountLinkingOptions, linkedAccount, disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount,
+ acc.fixedEmiAmount, acc.maxOutstandingLoanBalance,
emiAmountVariations, acc.memberVariations, acc.product, acc.inArrears,
acc.graceOnArrearsAgeing, overdueCharges, acc.isNPA,
acc.daysInMonthType, acc.daysInYearType,
acc.isInterestRecalculationEnabled,
acc.interestRecalculationData, acc.originalSchedule,
acc.createStandingInstructionAtDisbursement, paidInAdvance,
interestRatesPeriods, acc.isVariableInstallmentsAllowed,
@@ -1348,22 +1355,22 @@ public final class LoanAccountData {
public static LoanAccountData associateGroup(final LoanAccountData acc,
final GroupGeneralData group) {
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, group, acc.loanType, acc.loanProductId,
acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
- acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
- acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
- acc.transactionProcessingStrategyOptions,
acc.interestRateFrequencyTypeOptions, acc.amortizationTypeOptions,
- acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions, acc.chargeOptions,
null,
- acc.loanOfficerOptions, acc.loanPurposeOptions,
acc.loanCollateralOptions, acc.calendarOptions,
+ acc.clientOfficeId, acc.clientExternalId, group, acc.loanType,
acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ acc.repaymentSchedule, acc.transactions, acc.charges,
acc.collateral, acc.guarantors, acc.meeting, acc.productOptions,
+ acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions, acc.repaymentFrequencyNthDayTypeOptions,
+ acc.repaymentFrequencyDaysOfWeekTypeOptions,
acc.transactionProcessingStrategyOptions, acc.interestRateFrequencyTypeOptions,
+ acc.amortizationTypeOptions, acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions,
+ acc.chargeOptions, null, acc.loanOfficerOptions,
acc.loanPurposeOptions, acc.loanCollateralOptions, acc.calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, acc.notes, acc.accountLinkingOptions,
acc.linkedAccount, acc.disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
acc.maxOutstandingLoanBalance, acc.emiAmountVariations,
acc.memberVariations, acc.product, acc.inArrears,
@@ -1414,22 +1421,22 @@ public final class LoanAccountData {
}
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
- acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
- acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
- acc.transactionProcessingStrategyOptions,
acc.interestRateFrequencyTypeOptions, acc.amortizationTypeOptions,
- acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions, acc.chargeOptions,
null,
- acc.loanOfficerOptions, acc.loanPurposeOptions,
acc.loanCollateralOptions, acc.calendarOptions,
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ acc.repaymentSchedule, acc.transactions, acc.charges,
acc.collateral, acc.guarantors, acc.meeting, acc.productOptions,
+ acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions, acc.repaymentFrequencyNthDayTypeOptions,
+ acc.repaymentFrequencyDaysOfWeekTypeOptions,
acc.transactionProcessingStrategyOptions, acc.interestRateFrequencyTypeOptions,
+ acc.amortizationTypeOptions, acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions,
+ acc.chargeOptions, null, acc.loanOfficerOptions,
acc.loanPurposeOptions, acc.loanCollateralOptions, acc.calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, acc.notes, acc.accountLinkingOptions,
acc.linkedAccount, acc.disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
acc.maxOutstandingLoanBalance, acc.emiAmountVariations,
memberVariations, acc.product, acc.inArrears,
@@ -1448,22 +1455,22 @@ public final class LoanAccountData {
.withCalendarData(acc.interestRecalculationData, calendarData,
compoundingCalendarData);
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
- acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
- acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
- acc.transactionProcessingStrategyOptions,
acc.interestRateFrequencyTypeOptions, acc.amortizationTypeOptions,
- acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions, acc.chargeOptions,
null,
- acc.loanOfficerOptions, acc.loanPurposeOptions,
acc.loanCollateralOptions, acc.calendarOptions,
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ acc.repaymentSchedule, acc.transactions, acc.charges,
acc.collateral, acc.guarantors, acc.meeting, acc.productOptions,
+ acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions, acc.repaymentFrequencyNthDayTypeOptions,
+ acc.repaymentFrequencyDaysOfWeekTypeOptions,
acc.transactionProcessingStrategyOptions, acc.interestRateFrequencyTypeOptions,
+ acc.amortizationTypeOptions, acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions,
+ acc.chargeOptions, null, acc.loanOfficerOptions,
acc.loanPurposeOptions, acc.loanCollateralOptions, acc.calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, acc.notes, acc.accountLinkingOptions,
acc.linkedAccount, acc.disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
acc.maxOutstandingLoanBalance, acc.emiAmountVariations,
acc.memberVariations, acc.product, acc.inArrears,
@@ -1477,22 +1484,22 @@ public final class LoanAccountData {
public static LoanAccountData withLoanCalendarData(final LoanAccountData
acc, final CalendarData calendarData) {
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
calendarData.getRepeatsOnNthDayOfMonth(), calendarData.getRepeatsOnDay(),
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
- acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
- acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
- acc.transactionProcessingStrategyOptions,
acc.interestRateFrequencyTypeOptions, acc.amortizationTypeOptions,
- acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions, acc.chargeOptions,
null,
- acc.loanOfficerOptions, acc.loanPurposeOptions,
acc.loanCollateralOptions, acc.calendarOptions,
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ calendarData.getRepeatsOnNthDayOfMonth(),
calendarData.getRepeatsOnDay(), acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ acc.repaymentSchedule, acc.transactions, acc.charges,
acc.collateral, acc.guarantors, acc.meeting, acc.productOptions,
+ acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions, acc.repaymentFrequencyNthDayTypeOptions,
+ acc.repaymentFrequencyDaysOfWeekTypeOptions,
acc.transactionProcessingStrategyOptions, acc.interestRateFrequencyTypeOptions,
+ acc.amortizationTypeOptions, acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions,
+ acc.chargeOptions, null, acc.loanOfficerOptions,
acc.loanPurposeOptions, acc.loanCollateralOptions, acc.calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, acc.notes, acc.accountLinkingOptions,
acc.linkedAccount, acc.disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
acc.maxOutstandingLoanBalance, acc.emiAmountVariations,
acc.memberVariations, acc.product, acc.inArrears,
@@ -1507,22 +1514,22 @@ public final class LoanAccountData {
public static LoanAccountData withOriginalSchedule(final LoanAccountData
acc, final LoanScheduleData originalSchedule) {
return new LoanAccountData(acc.id, acc.accountNo, acc.status,
acc.externalId, acc.clientId, acc.clientAccountNo, acc.clientName,
- acc.clientOfficeId, acc.group, acc.loanType,
acc.loanProductId, acc.loanProductName, acc.loanProductDescription,
- acc.isLoanProductLinkedToFloatingRate, acc.fundId,
acc.fundName, acc.loanPurposeId, acc.loanPurposeName, acc.loanOfficerId,
- acc.loanOfficerName, acc.currency, acc.proposedPrincipal,
acc.principal, acc.approvedPrincipal, acc.netDisbursalAmount,
- acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
acc.termPeriodFrequencyType, acc.numberOfRepayments,
- acc.repaymentEvery, acc.repaymentFrequencyType,
acc.repaymentFrequencyNthDayType, acc.repaymentFrequencyDayOfWeekType,
- acc.transactionProcessingStrategyId,
acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod,
- acc.interestRateFrequencyType, acc.annualInterestRate,
acc.interestType, acc.isFloatingInterestRate,
- acc.interestRateDifferential,
acc.interestCalculationPeriodType, acc.allowPartialPeriodInterestCalculation,
- acc.expectedFirstRepaymentOnDate, acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods,
- acc.graceOnInterestPayment, acc.graceOnInterestCharged,
acc.interestChargedFromDate, acc.timeline, acc.summary,
- acc.feeChargesAtDisbursementCharged, acc.repaymentSchedule,
acc.transactions, acc.charges, acc.collateral, acc.guarantors,
- acc.meeting, acc.productOptions, acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions,
- acc.repaymentFrequencyNthDayTypeOptions,
acc.repaymentFrequencyDaysOfWeekTypeOptions,
- acc.transactionProcessingStrategyOptions,
acc.interestRateFrequencyTypeOptions, acc.amortizationTypeOptions,
- acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions, acc.chargeOptions,
null,
- acc.loanOfficerOptions, acc.loanPurposeOptions,
acc.loanCollateralOptions, acc.calendarOptions,
+ acc.clientOfficeId, acc.clientExternalId, acc.group,
acc.loanType, acc.loanProductId, acc.loanProductName,
+ acc.loanProductDescription,
acc.isLoanProductLinkedToFloatingRate, acc.fundId, acc.fundName,
acc.loanPurposeId,
+ acc.loanPurposeName, acc.loanOfficerId, acc.loanOfficerName,
acc.currency, acc.proposedPrincipal, acc.principal,
+ acc.approvedPrincipal, acc.netDisbursalAmount,
acc.totalOverpaid, acc.inArrearsTolerance, acc.termFrequency,
+ acc.termPeriodFrequencyType, acc.numberOfRepayments,
acc.repaymentEvery, acc.repaymentFrequencyType,
+ acc.repaymentFrequencyNthDayType,
acc.repaymentFrequencyDayOfWeekType, acc.transactionProcessingStrategyId,
+ acc.transactionProcessingStrategyName, acc.amortizationType,
acc.interestRatePerPeriod, acc.interestRateFrequencyType,
+ acc.annualInterestRate, acc.interestType,
acc.isFloatingInterestRate, acc.interestRateDifferential,
+ acc.interestCalculationPeriodType,
acc.allowPartialPeriodInterestCalculation, acc.expectedFirstRepaymentOnDate,
+ acc.graceOnPrincipalPayment,
acc.recurringMoratoriumOnPrincipalPeriods, acc.graceOnInterestPayment,
+ acc.graceOnInterestCharged, acc.interestChargedFromDate,
acc.timeline, acc.summary, acc.feeChargesAtDisbursementCharged,
+ acc.repaymentSchedule, acc.transactions, acc.charges,
acc.collateral, acc.guarantors, acc.meeting, acc.productOptions,
+ acc.termFrequencyTypeOptions,
acc.repaymentFrequencyTypeOptions, acc.repaymentFrequencyNthDayTypeOptions,
+ acc.repaymentFrequencyDaysOfWeekTypeOptions,
acc.transactionProcessingStrategyOptions, acc.interestRateFrequencyTypeOptions,
+ acc.amortizationTypeOptions, acc.interestTypeOptions,
acc.interestCalculationPeriodTypeOptions, acc.fundOptions,
+ acc.chargeOptions, null, acc.loanOfficerOptions,
acc.loanPurposeOptions, acc.loanCollateralOptions, acc.calendarOptions,
acc.syncDisbursementWithMeeting, acc.loanCounter,
acc.loanProductCounter, acc.notes, acc.accountLinkingOptions,
acc.linkedAccount, acc.disbursementDetails,
acc.multiDisburseLoan, acc.canDefineInstallmentAmount, acc.fixedEmiAmount,
acc.maxOutstandingLoanBalance, acc.emiAmountVariations,
acc.memberVariations, acc.product, acc.inArrears,
@@ -1538,7 +1545,8 @@ public final class LoanAccountData {
final String accountNo, //
final LoanStatusEnumData status, //
final String externalId, //
- final Long clientId, final String clientAccountNo, final String
clientName, final Long clientOfficeId, //
+ final Long clientId, final String clientAccountNo, final String
clientName, final Long clientOfficeId,
+ final String clientExternalId, //
final GroupGeneralData group, final EnumOptionData loanType, final
Long loanProductId, final String loanProductName,
final String loanProductDescription, //
final boolean isLoanProductLinkedToFloatingRate, final Long
fundId, final String fundName, final Long loanPurposeId,
@@ -1596,6 +1604,7 @@ public final class LoanAccountData {
this.clientAccountNo = clientAccountNo;
this.clientName = clientName;
this.clientOfficeId = clientOfficeId;
+ this.clientExternalId = clientExternalId;
this.group = group;
this.loanType = loanType;
this.loanProductId = loanProductId;
diff --git
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
index bd7633b2a..45b1889eb 100644
---
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
+++
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
@@ -388,7 +388,7 @@ public class LoanReadPlatformServiceImpl implements
LoanReadPlatformService {
final ClientData clientAccount =
this.clientReadPlatformService.retrieveOne(clientId);
final LocalDate expectedDisbursementDate =
DateUtils.getBusinessLocalDate();
LoanAccountData loanTemplateDetails =
LoanAccountData.clientDefaults(clientAccount.getId(),
clientAccount.getAccountNo(),
- clientAccount.getDisplayName(), clientAccount.getOfficeId(),
expectedDisbursementDate);
+ clientAccount.getDisplayName(), clientAccount.getOfficeId(),
clientAccount.getExternalId(), expectedDisbursementDate);
if (productId != null) {
final LoanProductData selectedProduct =
this.loanProductReadPlatformService.retrieveLoanProduct(productId);
@@ -612,7 +612,7 @@ public class LoanReadPlatformServiceImpl implements
LoanReadPlatformService {
+ " lp.allow_variabe_installments as
isvariableInstallmentsAllowed, "
+ " lp.allow_multiple_disbursals as multiDisburseLoan,"
+ " lp.can_define_fixed_emi_amount as
canDefineInstallmentAmount,"
- + " c.id as clientId, c.account_no as clientAccountNo,
c.display_name as clientName, c.office_id as clientOfficeId,"
+ + " c.id as clientId, c.account_no as clientAccountNo,
c.display_name as clientName, c.office_id as clientOfficeId, c.external_id as
clientExternalId,"
+ " g.id as groupId, g.account_no as groupAccountNo,
g.display_name as groupName,"
+ " g.office_id as groupOfficeId, g.staff_id As
groupStaffId , g.parent_id as groupParentId, (select mg.display_name from
m_group mg where mg.id = g.parent_id) as centerName, "
+ " g.hierarchy As groupHierarchy , g.level_id as
groupLevel, g.external_id As groupExternalId, "
@@ -725,6 +725,7 @@ public class LoanReadPlatformServiceImpl implements
LoanReadPlatformService {
final Long clientId = JdbcSupport.getLong(rs, "clientId");
final String clientAccountNo = rs.getString("clientAccountNo");
final Long clientOfficeId = JdbcSupport.getLong(rs,
"clientOfficeId");
+ final String clientExternalId = rs.getString("clientExternalId");
final String clientName = rs.getString("clientName");
final Long groupId = JdbcSupport.getLong(rs, "groupId");
@@ -1010,7 +1011,7 @@ public class LoanReadPlatformServiceImpl implements
LoanReadPlatformService {
DelinquencyRangeData delinquencyRange =
this.delinquencyReadPlatformService.retrieveCurrentDelinquencyTag(id);
return LoanAccountData.basicLoanDetails(id, accountNo, status,
externalId, clientId, clientAccountNo, clientName,
- clientOfficeId, groupData, loanType, loanProductId,
loanProductName, loanProductDescription,
+ clientOfficeId, clientExternalId, groupData, loanType,
loanProductId, loanProductName, loanProductDescription,
isLoanProductLinkedToFloatingRate, fundId, fundName,
loanPurposeId, loanPurposeName, loanOfficerId, loanOfficerName,
currencyData, proposedPrincipal, principal,
approvedPrincipal, netDisbursalAmount, totalOverpaid, inArrearsTolerance,
termFrequency, termPeriodFrequencyType,
numberOfRepayments, repaymentEvery, repaymentFrequencyType, null, null,
@@ -1482,7 +1483,7 @@ public class LoanReadPlatformServiceImpl implements
LoanReadPlatformService {
final LocalDate expectedDisbursementDate =
DateUtils.getBusinessLocalDate();
return LoanAccountData.clientDefaults(clientAccount.getId(),
clientAccount.getAccountNo(), clientAccount.getDisplayName(),
- clientAccount.getOfficeId(), expectedDisbursementDate);
+ clientAccount.getOfficeId(), clientAccount.getExternalId(),
expectedDisbursementDate);
}
@Override
