galovics commented on code in PR #2591:
URL: https://github.com/apache/fineract/pull/2591#discussion_r969650346
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -135,10 +144,6 @@ private void adjustColumnTypes() {
}
}
- public boolean isNamed(final String columnName) {
Review Comment:
Why delete this one?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -305,14 +274,6 @@ public boolean isColumnValueAllowed(final String match) {
return allowed;
}
- public boolean isColumnValueNotAllowed(final String match) {
- return !isColumnValueAllowed(match);
- }
-
- public boolean isColumnCodeNotAllowed(final Integer match) {
Review Comment:
Why delete this one?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -305,14 +274,6 @@ public boolean isColumnValueAllowed(final String match) {
return allowed;
}
- public boolean isColumnValueNotAllowed(final String match) {
Review Comment:
Why delete this one?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1203,11 +1203,11 @@ private CommandProcessingResult
updateDatatableEntry(final String dataTableName,
final GenericResultsetData grs =
retrieveDataTableGenericResultSetForUpdate(appTable, dataTableName, appTableId,
datatableId);
- if (grs.hasNoEntries()) {
+ if (grs.getData().isEmpty()) {
throw new DatatableNotFoundException(dataTableName, appTableId);
}
- if (grs.hasMoreThanOneEntry()) {
Review Comment:
Why deleted the original method?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -283,18 +264,6 @@ public boolean isCodeLookupDisplayType() {
return "CODELOOKUP".equalsIgnoreCase(this.columnDisplayType);
}
- public boolean isMandatory() {
- return !isOptional();
- }
-
- public boolean isOptional() {
Review Comment:
Why delete this one?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -283,18 +264,6 @@ public boolean isCodeLookupDisplayType() {
return "CODELOOKUP".equalsIgnoreCase(this.columnDisplayType);
}
- public boolean isMandatory() {
Review Comment:
Why delete this one?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -283,18 +264,6 @@ public boolean isCodeLookupDisplayType() {
return "CODELOOKUP".equalsIgnoreCase(this.columnDisplayType);
}
- public boolean isMandatory() {
- return !isOptional();
- }
-
- public boolean isOptional() {
- return this.isColumnNullable;
- }
-
- public boolean hasColumnValues() {
Review Comment:
Why delete this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
