galovics commented on code in PR #2603:
URL: https://github.com/apache/fineract/pull/2603#discussion_r972948445
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java:
##########
@@ -18,7 +18,13 @@
*/
package org.apache.fineract.infrastructure.event.external.repository;
+import java.util.List;
import
org.apache.fineract.infrastructure.event.external.repository.domain.ExternalEvent;
+import
org.apache.fineract.infrastructure.event.external.repository.domain.ExternalEventStatus;
+import org.springframework.data.domain.Pageable;
import org.springframework.data.jpa.repository.JpaRepository;
-public interface ExternalEventRepository extends JpaRepository<ExternalEvent,
Long> {}
+public interface ExternalEventRepository extends JpaRepository<ExternalEvent,
Long> {
+
+ List<ExternalEvent> findFirst1000ByStatusOrderById(ExternalEventStatus
status, Pageable batchSize);
Review Comment:
Since you're passing a Pageable object, there's no need to specify
"First1000" in the method name. Just leave it out and it should work as
expected.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/message/MessageFactory.java:
##########
@@ -33,10 +37,17 @@
import
org.apache.fineract.infrastructure.event.external.service.message.domain.MessageIdempotencyKey;
import
org.apache.fineract.infrastructure.event.external.service.message.domain.MessageSource;
import
org.apache.fineract.infrastructure.event.external.service.message.domain.MessageType;
+import
org.apache.fineract.infrastructure.event.external.service.support.ByteBufferConverter;
+import org.springframework.beans.factory.InitializingBean;
import org.springframework.stereotype.Component;
+@Slf4j
@Component
-public class MessageFactory {
+@RequiredArgsConstructor
+public class MessageFactory implements InitializingBean {
+
+ private final ByteBufferConverter byteBufferConverter;
+ private static final String sourceUUID = UUID.randomUUID().toString();
Review Comment:
Naming convention. Should be named as SOURCE_UUID according to the Java
standards.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/message/MessageFactory.java:
##########
@@ -73,4 +97,9 @@ private String getMessageCreatedAt() {
OffsetDateTime createdAt = DateUtils.getOffsetDateTimeOfTenant();
return
createdAt.withOffsetSameInstant(ZoneOffset.UTC).toLocalDateTime().format(DateTimeFormatter.ISO_LOCAL_DATE_TIME);
}
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ log.info("Message source set to " + sourceUUID);
Review Comment:
Instead of concatenating the 2 values, use log message placeholders.
(`log.info("Message source set to {}", sourceUUID);`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
