adamsaghy commented on code in PR #2633:
URL: https://github.com/apache/fineract/pull/2633#discussion_r990942828
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3362,14 +3369,18 @@ private List<LoanTransaction>
retreiveListOfAccrualTransactions() {
return transactions;
}
- private void doPostLoanTransactionChecks(final LocalDate transactionDate,
final LoanLifecycleStateMachine loanLifecycleStateMachine) {
-
+ private boolean doPostLoanTransactionChecks(final LocalDate
transactionDate,
+ final LoanLifecycleStateMachine loanLifecycleStateMachine) {
+ boolean statusChanged = false;
if (isOverPaid()) {
// FIXME - kw - update account balance to negative amount.
handleLoanOverpayment(loanLifecycleStateMachine);
- } else if (this.summary.isRepaidInFull(loanCurrency())) {
Review Comment:
Minor: `isRepaidInFull()` and
`this.summary.getTotalOutstanding(loanCurrency()).isZero()` is the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
