galovics commented on code in PR #2587:
URL: https://github.com/apache/fineract/pull/2587#discussion_r994494214
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java:
##########
@@ -112,34 +120,8 @@ public class SmsCampaign extends AbstractPersistableCustom
{
@Column(name = "is_visible", nullable = true)
private boolean isVisible;
- @Column(name = "is_notification", nullable = true)
- private boolean isNotification;
-
- public SmsCampaign() {}
-
- private SmsCampaign(final String campaignName, final Integer campaignType,
final Integer triggerType, final Report businessRuleId,
- final Long providerId, final String paramValue, final String
message, final LocalDate submittedOnDate,
- final AppUser submittedBy, final String recurrence, final
LocalDateTime localDateTime, final boolean isNotification) {
- this.campaignName = campaignName;
- this.campaignType = campaignType;
- this.triggerType =
SmsCampaignTriggerType.fromInt(triggerType).getValue();
- this.businessRuleId = businessRuleId;
- this.providerId = providerId;
- this.paramValue = paramValue;
- this.status = SmsCampaignStatus.PENDING.getValue();
- this.message = message;
- this.submittedOnDate = submittedOnDate;
- this.submittedBy = submittedBy;
- this.recurrence = recurrence;
- LocalDateTime recurrenceStartDate =
LocalDateTime.now(DateUtils.getDateTimeZoneOfTenant());
Review Comment:
Logic missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
