ezolnbl-dpc commented on code in PR #2659:
URL: https://github.com/apache/fineract/pull/2659#discussion_r994868830


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/DatatablesApiResource.java:
##########
@@ -218,6 +226,55 @@ public String getDatatable(@PathParam("datatable") 
@Parameter(description = "dat
         return this.toApiJsonSerializer.serializePretty(prettyPrint, result);
     }
 
+    @GET
+    @Path("{datatable}/query")
+    @Produces({ MediaType.APPLICATION_JSON })
+    @Operation(summary = "Query Data Table values", description = "Query 
values from a registered data table.")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = 
@Content(schema = @Schema(implementation = List.class))) })
+    public String queryValues(@PathParam("datatable") @Parameter(description = 
"datatable") final String datatable,
+            @QueryParam("columnFilter") @Parameter(description = 
"columnFilter") final String columnFilter,
+            @QueryParam("valueFilter") @Parameter(description = "valueFilter") 
final String valueFilter,
+            @QueryParam("resultColumns") @Parameter(description = 
"resultColumns") final String resultColumns,
+            @Context final UriInfo uriInfo) {
+        
this.context.authenticatedUser().validateHasDatatableReadPermission(datatable);
+        List<String> dataTableColumnNames = 
genericDataService.fillResultsetColumnHeaders(datatable).stream()
+                .map(ResultsetColumnHeaderData::getColumnName).toList();
+        List<ApiParameterError> paramErrors = new ArrayList<>();
+        if (columnFilter == null || columnFilter.isEmpty()) {
+            paramErrors.add(parameterErrorWithValue("400", "Column filter is 
empty!", "columnFilter", columnFilter));
+        } else {
+            if (!dataTableColumnNames.contains(columnFilter)) {
+                paramErrors.add(parameterErrorWithValue("400", "Column filter 
not exist in datatable!", "columnFilter", columnFilter));
+            }
+        }
+
+        if (valueFilter == null || valueFilter.isEmpty()) {
+            paramErrors.add(parameterErrorWithValue("400", "Value filter is 
empty!", "valueFilter", valueFilter));
+        }
+
+        if (resultColumns == null || resultColumns.isEmpty()) {
+            paramErrors.add(parameterErrorWithValue("400", "Result columns 
filter is empty!", "resultColumns", resultColumns));
+        } else {
+            List<String> resultColumnNames = 
Stream.of(resultColumns.split(",")).toList();

Review Comment:
   done



##########
build.gradle:
##########
@@ -171,6 +171,7 @@ allprojects  {
         reportDir = file("$buildDir/reports/rat")
         excludes = [
             '**/src/main/templates/**/*.mustache',
+            '**/src/main/generated/**',

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to