galovics commented on code in PR #2659:
URL: https://github.com/apache/fineract/pull/2659#discussion_r995500535
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java:
##########
@@ -35,7 +35,7 @@ private SQLInjectionValidator() {
private static final String[] COMMENTS = { "--", "({", "/*", "#" };
- private static final String SQL_PATTERN = "[a-zA-Z_=,\\-'!><.?\"`%
()0-9*\n\r]*";
+ private static final String SQL_PATTERN = "[a-zA-Z_=,\\-:'!><.?\"`%
()0-9*\n\r]*";
Review Comment:
Yeah I got it you didn't want to touch it but the thing is you did hence the
testing is on you. Please add proper test cases to cover this functionality
(not only for your date case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
