josehernandezfintecheandomx commented on code in PR #2668:
URL: https://github.com/apache/fineract/pull/2668#discussion_r995690391


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java:
##########
@@ -134,8 +144,61 @@ public CommandProcessingResult 
deleteDelinquencyBucket(Long delinquencyBucketId,
                         "Data integrity issue with resource: " + 
delinquencyBucket.getId());
             }
             repositoryBucket.delete(delinquencyBucket);
+            return new 
CommandProcessingResultBuilder().withCommandId(command.commandId()).withEntityId(delinquencyBucket.getId()).build();
         }
-        return new 
CommandProcessingResultBuilder().withCommandId(command.commandId()).withEntityId(delinquencyBucket.getId()).build();
+        return new 
CommandProcessingResultBuilder().withCommandId(command.commandId()).withEntityId(delinquencyBucketId).build();
+    }
+
+    @Override
+    public LoanScheduleDelinquencyData 
getOverdueDays(LoanScheduleDelinquencyData loanScheduleDelinquencyData) {
+        final Loan loan = 
this.loanRepository.findOneWithNotFoundDetection(loanScheduleDelinquencyData.getLoanId());
+        loanScheduleDelinquencyData.setLoan(loan);
+        loanScheduleDelinquencyData.setOverdueDays(getOverdueDays(loan));
+        return loanScheduleDelinquencyData;
+    }
+
+    @Override
+    public Long getOverdueDays(Loan loan) {

Review Comment:
   The idea is to have the overdue loan installments, one case is with the 
overdue direct and the second is througj tje loan transaction charge back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to