adamsaghy commented on code in PR #2672:
URL: https://github.com/apache/fineract/pull/2672#discussion_r995841542
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java:
##########
@@ -62,7 +65,7 @@ private LoanStatus getNextState(LoanEvent loanEvent, Loan
loan) {
}
LoanStatus from = loan.status();
- LoanStatus newState = from;
+ LoanStatus newState = null;
Review Comment:
To avoid sending out from "ACTIVE" to "ACTIVE" events. Either we are not
indicating with the result that there was no state change or we need to check
the before & after and decide based on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
