galovics commented on code in PR #2689:
URL: https://github.com/apache/fineract/pull/2689#discussion_r1001918028


##########
fineract-doc/src/docs/en/chapters/architecture/modules.adoc:
##########
@@ -63,6 +63,15 @@ If database migrations are needed as part of your 
customizations then you can ad
 include::{diagramsdir}/custom-db-migration-folder-structure.puml[]
 ----
 
+And here an example migration script:
+
+[source,xml]
+----
+include::{rootdir}/custom/acme/note/starter/src/main/resources/db/custom-changelog/0001_acme_note_initial.xml[lines=22..]
+----
+
+IMPORTANT: Please make sure your `changeSet` tag has the attribute `context` 
set to `tenant_db`. That makes sure your changes will be applied to the tenant 
database (read: main database and not the tenant store database). In theory you 
could also target the tenant configuration database, but it's not recommended 
to do that.

Review Comment:
   I mean here:
   
   ```
   <includeAll path="db/custom-changelog" errorIfMissingOrEmpty="false"  />
   ```
   We could also set the context that the custom changelog is only picked up 
for `tenant_db`. That way nobody can screw up the tenant config DB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to