adamsaghy commented on code in PR #2668:
URL: https://github.com/apache/fineract/pull/2668#discussion_r1003129089
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/CollectionData.java:
##########
@@ -20,71 +20,27 @@
import java.math.BigDecimal;
import java.time.LocalDate;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.Setter;
+@AllArgsConstructor
+@Getter
+@Setter
public final class CollectionData {
- private final BigDecimal availableDisbursementAmount;
- private final int pastDueDays;
- private final LocalDate nextPaymentDueDate;
- private final int delinquentDays;
- private final LocalDate delinquentDate;
- private final BigDecimal delinquentAmount;
- private final LocalDate lastPaymentDate;
- private final BigDecimal lastPaymentAmount;
-
- private CollectionData(BigDecimal availableDisbursementAmount, int
pastDueDays, LocalDate nextPaymentDueDate, int delinquentDays,
- LocalDate delinquentDate, BigDecimal delinquentAmount, LocalDate
lastPaymentDate, BigDecimal lastPaymentAmount) {
- this.availableDisbursementAmount = availableDisbursementAmount;
- this.pastDueDays = pastDueDays;
- this.nextPaymentDueDate = nextPaymentDueDate;
- this.delinquentDays = delinquentDays;
- this.delinquentDate = delinquentDate;
- this.delinquentAmount = delinquentAmount;
- this.lastPaymentDate = lastPaymentDate;
- this.lastPaymentAmount = lastPaymentAmount;
- }
-
- public static CollectionData instance(BigDecimal
availableDisbursementAmount, int pastDueDays, LocalDate nextPaymentDueDate,
- int delinquentDays, LocalDate delinquentDate, BigDecimal
delinquentAmount, LocalDate lastPaymentDate,
- BigDecimal lastPaymentAmount) {
- return new CollectionData(availableDisbursementAmount, pastDueDays,
nextPaymentDueDate, delinquentDays, delinquentDate,
- delinquentAmount, lastPaymentDate, lastPaymentAmount);
- }
+ private BigDecimal availableDisbursementAmount;
+ private int pastDueDays;
Review Comment:
Change to long and we can avoid back and forth conversation between Integer
and Long (int and long)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
