adamsaghy commented on code in PR #2692:
URL: https://github.com/apache/fineract/pull/2692#discussion_r1003149720
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java:
##########
@@ -164,6 +164,22 @@ private GetLoanTransactionRelation() {}
public String reversalExternalId;
@Schema(example = "[2012, 5, 18]")
public LocalDate reversedOnDate;
+ @Schema(example = "1000.00")
Review Comment:
netDisbursalAmount has nothing to do with Loan transaction. Please remove!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java:
##########
@@ -164,6 +164,22 @@ private GetLoanTransactionRelation() {}
public String reversalExternalId;
@Schema(example = "[2012, 5, 18]")
public LocalDate reversedOnDate;
+ @Schema(example = "1000.00")
+ public Double netDisbursalAmount;
+ @Schema(example = "240.00")
+ public Double principalPortion;
+ @Schema(example = "23.90")
+ public Double feeChargesPortion;
+ @Schema(example = "12.80")
+ public Double penaltyChargesPortion;
+ @Schema(example = "33.00")
+ public Double overpaymentPortion;
+ @Schema(example = "55.50")
+ public Double unrecognizedIncomePortion;
+ @Schema(example = "100.00")
+ public Double outstandingLoanBalance;
+ @Schema(example = "[2012, 5, 18]")
+ public LocalDate possibleNextRepaymentDate;
Review Comment:
possibleNextRepaymentDate has nothing to do with Loan transaction. Please
remove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
