adamsaghy commented on code in PR #2739:
URL: https://github.com/apache/fineract/pull/2739#discussion_r1023669228
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -6781,15 +6781,19 @@ public Collection<LoanCharge> getLoanCharges() {
public void initializeLazyCollections() {
checkAndFetchLazyCollection(this.charges);
checkAndFetchLazyCollection(this.trancheCharges);
- checkAndFetchLazyCollection(this.repaymentScheduleInstallments);
- checkAndFetchLazyCollection(this.loanTransactions);
+ initializeLazyBasicCollections();
checkAndFetchLazyCollection(this.disbursementDetails);
checkAndFetchLazyCollection(this.loanTermVariations);
checkAndFetchLazyCollection(this.collateral);
checkAndFetchLazyCollection(this.loanOfficerHistory);
checkAndFetchLazyCollection(this.loanCollateralManagements);
}
+ public void initializeLazyBasicCollections() {
Review Comment:
Please rename this. "Basic collections" is really non-descriptive method
name. Suggestion: `fetchRepaymentScheduleAndTransactions()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
