adamsaghy commented on code in PR #2750:
URL: https://github.com/apache/fineract/pull/2750#discussion_r1028458912
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1415,14 +1415,22 @@ private CommandProcessingResult
updateDatatableEntry(final String dataTableName,
}
}
- return new CommandProcessingResultBuilder() //
+ CommandProcessingResultBuilder result = new
CommandProcessingResultBuilder() //
+ .withCommandId(command.commandId()) //
.withOfficeId(commandProcessingResult.getOfficeId()) //
.withGroupId(commandProcessingResult.getGroupId()) //
.withClientId(commandProcessingResult.getClientId()) //
.withSavingsId(commandProcessingResult.getSavingsId()) //
.withLoanId(commandProcessingResult.getLoanId()) //
- .with(changes) //
- .build();
+ .with(changes);
+
+ if (command.subentityId() != null) {
+ result = result.withEntityId(command.subentityId());
Review Comment:
Personally i would do this:
```
new CommandProcessingResultBuilder().withEntityId(datatableId != null?
datatableId : appTableId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
