galovics commented on code in PR #2758:
URL: https://github.com/apache/fineract/pull/2758#discussion_r1031771133
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java:
##########
@@ -541,8 +539,10 @@ public CommandProcessingResult
refundByTransfer(JsonCommand command) {
throw new
InvalidPaidInAdvanceAmountException(overpaid.toPlainString());
}
+ ExternalId externalId = externalIdFactory.fromString(null);
Review Comment:
Same as above.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java:
##########
@@ -193,9 +177,9 @@ toLoanAccount, new CommandProcessingResultBuilder(),
transactionDate, transactio
fromLoanAccountId =
command.longValueOfParameterNamed(fromAccountIdParamName);
final Loan fromLoanAccount =
this.loanAccountAssembler.assembleFrom(fromLoanAccountId);
-
+ ExternalId externalId = externalIdFactory.fromString(null);
Review Comment:
Why not just use ExternalId.empty() here?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/serialization/CollectionSheetBulkRepaymentCommandFromApiJsonDeserializer.java:
##########
@@ -90,14 +91,17 @@ public CollectionSheetBulkRepaymentCommand
commandFromApiJson(final String json,
final JsonObject loanTransactionElement =
array.get(i).getAsJsonObject();
final Long loanId =
this.fromApiJsonHelper.extractLongNamed("loanId", loanTransactionElement);
+ final String externalIdStr =
this.fromApiJsonHelper.extractStringNamed("externalId", loanTransactionElement);
+ final ExternalId externalId = new
ExternalId(externalIdStr);
Review Comment:
Isn't this gonna be an issue in case the externalId param was not provided?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/service/GuarantorDomainServiceImpl.java:
##########
@@ -245,11 +249,11 @@ public void transaferFundsFromGuarantor(final Loan loan) {
remainingAmount =
remainingAmount.multiply(loan.getPrincipal().getAmount()).divide(loan.getGuaranteeAmount(),
MoneyHelper.getRoundingMode());
}
+ ExternalId externalId =
externalIdFactory.fromString(null);
Review Comment:
ExternalId.empty?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -730,8 +725,10 @@ public Map<String, Object> foreCloseLoan(final Loan loan,
final LocalDate foreCl
Money penaltyPortion =
foreCloseDetail.getPenaltyChargesCharged(currency).minus(accruedReceivables[2]);
Money total =
interestPortion.plus(feePortion).plus(penaltyPortion);
if (total.isGreaterThanZero()) {
+ ExternalId accrualExternalId =
externalIdFactory.fromString(null);
Review Comment:
ExternalId.empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
