adamsaghy commented on code in PR #2777:
URL: https://github.com/apache/fineract/pull/2777#discussion_r1034877184
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineLoanCOBBuildExecutionContextTasklet.java:
##########
@@ -37,30 +41,41 @@
import org.springframework.batch.core.scope.context.ChunkContext;
import org.springframework.batch.core.step.tasklet.Tasklet;
import org.springframework.batch.repeat.RepeatStatus;
-import org.springframework.stereotype.Component;
@Slf4j
@RequiredArgsConstructor
-@Component
public class InlineLoanCOBBuildExecutionContextTasklet implements Tasklet {
- private final GoogleGsonSerializerHelper gsonFactory;
private final COBBusinessStepService cobBusinessStepService;
private final CustomJobParameterRepository customJobParameterRepository;
private final Gson gson = GoogleGsonSerializerHelper.createSimpleGson();
@Override
public RepeatStatus execute(StepContribution contribution, ChunkContext
chunkContext) throws Exception {
+ HashMap<BusinessDateType, LocalDate> businessDates =
ThreadLocalContextUtil.getBusinessDates();
ThreadLocalContextUtil.setActionContext(ActionContext.COB);
TreeMap<Long, String> cobBusinessStepMap =
cobBusinessStepService.getCOBBusinessStepMap(LoanCOBBusinessStep.class,
LoanCOBConstant.LOAN_COB_JOB_NAME);
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.LOAN_IDS,
getLoanIdsFromJobParameters(chunkContext));
+ String businessDate = getBusinessDateFromJobParameters(chunkContext);
+
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.BUSINESS_DATE_PARAMETER_NAME,
businessDate);
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.BUSINESS_STEP_MAP,
cobBusinessStepMap);
-
+ businessDates.put(BusinessDateType.COB_DATE,
LocalDate.parse(businessDate, DateTimeFormatter.ISO_DATE));
+ businessDates.put(BusinessDateType.BUSINESS_DATE,
LocalDate.parse(businessDate, DateTimeFormatter.ISO_DATE).plusDays(1));
Review Comment:
You can save some perf on not doing the parse twice...
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineLoanCOBBuildExecutionContextTasklet.java:
##########
@@ -37,30 +41,41 @@
import org.springframework.batch.core.scope.context.ChunkContext;
import org.springframework.batch.core.step.tasklet.Tasklet;
import org.springframework.batch.repeat.RepeatStatus;
-import org.springframework.stereotype.Component;
@Slf4j
@RequiredArgsConstructor
-@Component
public class InlineLoanCOBBuildExecutionContextTasklet implements Tasklet {
- private final GoogleGsonSerializerHelper gsonFactory;
private final COBBusinessStepService cobBusinessStepService;
private final CustomJobParameterRepository customJobParameterRepository;
private final Gson gson = GoogleGsonSerializerHelper.createSimpleGson();
@Override
public RepeatStatus execute(StepContribution contribution, ChunkContext
chunkContext) throws Exception {
+ HashMap<BusinessDateType, LocalDate> businessDates =
ThreadLocalContextUtil.getBusinessDates();
ThreadLocalContextUtil.setActionContext(ActionContext.COB);
TreeMap<Long, String> cobBusinessStepMap =
cobBusinessStepService.getCOBBusinessStepMap(LoanCOBBusinessStep.class,
LoanCOBConstant.LOAN_COB_JOB_NAME);
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.LOAN_IDS,
getLoanIdsFromJobParameters(chunkContext));
+ String businessDate = getBusinessDateFromJobParameters(chunkContext);
+
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.BUSINESS_DATE_PARAMETER_NAME,
businessDate);
contribution.getStepExecution().getExecutionContext().put(LoanCOBConstant.BUSINESS_STEP_MAP,
cobBusinessStepMap);
-
+ businessDates.put(BusinessDateType.COB_DATE,
LocalDate.parse(businessDate, DateTimeFormatter.ISO_DATE));
+ businessDates.put(BusinessDateType.BUSINESS_DATE,
LocalDate.parse(businessDate, DateTimeFormatter.ISO_DATE).plusDays(1));
Review Comment:
You can save some perf on not doing the parsing twice...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
