adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1040888121
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepositoryWrapper.java:
##########
@@ -86,8 +87,21 @@ public Client getActiveClientInUserScope(Long clientId) {
public Client getClientByAccountNumber(String accountNumber) {
Client client =
this.repository.getClientByAccountNumber(accountNumber);
if (client == null) {
- throw new ClientNotFoundException(accountNumber);
+ throw new ClientNotFoundException(accountNumber, "account.number");
}
return client;
}
+
+ public Client getClientByClientId(final Long clientId, final String
hierarchySearchString) {
Review Comment:
Wrong method name. It get clients by cliendId and hierarchy, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
