galovics commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1048940880
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java:
##########
@@ -559,11 +559,143 @@ public Collection<ClientData>
retrieveActiveClientMembersOfCenter(final Long cen
hierarchySearchString, centerId,
ClientStatus.ACTIVE.getValue());
}
- private static final class ClientMapper implements RowMapper<ClientData> {
+ private static final class ParentGroupsMapper implements
RowMapper<GroupGeneralData> {
Review Comment:
Why has this (and the below classes) been reordered?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java:
##########
@@ -165,7 +153,7 @@ private String generateAccountNumber(Map<String, String>
propertyMap, AccountNum
prefix = prefix.substring(0, Math.min(prefix.length(), 10));
}
if
(accountNumberPrefixType.getValue().equals(AccountNumberPrefixType.PREFIX_SHORT_NAME.getValue()))
{
- Integer prefixLength = prefix.length();
+ Integer prefixLength = prefix == null ? 10 : prefix.length();
Review Comment:
Is this needed for the externalId work? Either revert this or cover with
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
