galovics commented on code in PR #2846:
URL: https://github.com/apache/fineract/pull/2846#discussion_r1058300525
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -47,6 +50,10 @@ protected <T> ByteBufferSerializable
toAvroDTO(BusinessEvent<T> rawEvent) {
LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
LoanAccountData data = service.retrieveOne(event.get().getId());
data = service.fetchRepaymentScheduleData(data);
+ final Collection<LoanTransactionData> currentLoanTransactions =
service.retrieveLoanTransactions(event.get().getId());
Review Comment:
Can we make this call optional and execute it in case the loan summary is
not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
