josehernandezfintecheandomx commented on code in PR #2845:
URL: https://github.com/apache/fineract/pull/2845#discussion_r1058543513
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargeTimeType.java:
##########
@@ -37,7 +37,8 @@ public enum ChargeTimeType {
SHAREACCOUNT_ACTIVATION(13, "chargeTimeType.activation"), // only for loan
SHARE_PURCHASE(14, "chargeTimeType.sharespurchase"), SHARE_REDEEM(15,
"chargeTimeType.sharesredeem"),
- SAVINGS_NOACTIVITY_FEE(16, "chargeTimeType.savingsNoActivityFee");
+ SAVINGS_NOACTIVITY_FEE(16, "chargeTimeType.savingsNoActivityFee"), // only
for savings
Review Comment:
Done removed!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeDropdownReadPlatformServiceImpl.java:
##########
@@ -102,7 +102,8 @@ public List<EnumOptionData>
retrieveSavingsCollectionTimeTypes() {
// chargeTimeType(ChargeTimeType.SAVINGS_CLOSURE),
chargeTimeType(ChargeTimeType.WITHDRAWAL_FEE),
chargeTimeType(ChargeTimeType.ANNUAL_FEE),
chargeTimeType(ChargeTimeType.MONTHLY_FEE),
chargeTimeType(ChargeTimeType.WEEKLY_FEE),
- chargeTimeType(ChargeTimeType.OVERDRAFT_FEE),
chargeTimeType(ChargeTimeType.SAVINGS_NOACTIVITY_FEE));
+ chargeTimeType(ChargeTimeType.OVERDRAFT_FEE),
chargeTimeType(ChargeTimeType.SAVINGS_NOACTIVITY_FEE),
Review Comment:
Done removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
