adamsaghy commented on code in PR #2852:
URL: https://github.com/apache/fineract/pull/2852#discussion_r1063435445
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1063,9 +1063,10 @@ public CommandProcessingResult
adjustLoanTransaction(final Long loanId, final Lo
transactionId);
}
- if (transactionToAdjust.isChargeback()) {
- throw new
PlatformServiceUnavailableException("error.msg.loan.transaction.update.not.allowed",
"Loan transaction:"
- + transactionId + " update not allowed as loan transaction
is charge back and is linked to other transaction",
+ if (transactionToAdjust.isChargeback() ||
transactionToAdjust.isGoodwillCredit() || transactionToAdjust.isPayoutRefund()
Review Comment:
This is not correct. We should let the undo, but the adjusting.
Please amend this logic whether it is just undo (transactionAmount=0) or
undo and create new (transactionAmount>0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
