adamsaghy commented on code in PR #2852:
URL: https://github.com/apache/fineract/pull/2852#discussion_r1073524648
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -430,7 +430,8 @@ public CommandProcessingResult updateClient(final Long
clientId, final JsonComma
}
final ExternalId externalId =
externalIdFactory.createFromCommand(command,
ClientApiConstants.externalIdParamName);
- if
(command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName,
externalId.getValue())) {
+ if
(command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName,
Review Comment:
Please raise a separate PR for fixing the client external id updating bug!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
