adamsaghy commented on code in PR #2882:
URL: https://github.com/apache/fineract/pull/2882#discussion_r1073680744


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -6341,41 +6349,19 @@ public Map<String, Object> 
undoLastDisbursal(ScheduleGeneratorDTO scheduleGenera
         return actualChanges;
     }
 
-    /**
-     * Reverse only disbursement, accruals, and repayments at disbursal 
transactions
-     *
-     * @param actualDisbursementDate
-     * @return
-     */
-    public List<LoanTransaction> 
reverseExistingTransactionsTillLastDisbursal(LocalDate actualDisbursementDate) {

Review Comment:
   Accrual and repayment at disbursal can be reversed even if it was after the 
last disbursement.
   Please be more careful to not do any regression!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to