galovics commented on code in PR #2891:
URL: https://github.com/apache/fineract/pull/2891#discussion_r1080999034


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/config/ExternalEventJMSConfiguration.java:
##########
@@ -60,4 +61,13 @@ public ActiveMQTopic activeMqTopic() {
     public ActiveMQQueue activeMqQueue() {
         return new 
ActiveMQQueue(fineractProperties.getEvents().getExternal().getProducer().getJms().getEventQueueName());
     }
+
+    @Bean("externalEventJmsProducerExecutor")
+    public ThreadPoolTaskExecutor externalEventJmsProducerExecutor() {
+        ThreadPoolTaskExecutor threadPoolTaskExecutor = new 
ThreadPoolTaskExecutor();
+        threadPoolTaskExecutor.setCorePoolSize(10);

Review Comment:
   It's just the core pool size, the threadpool can grow until the max pool 
size is reached (100 threads) but that's already a value nobody will utilize in 
my opinion. Essentially it'd mean 100 parallel producers.
   
   Based on my initial measurement the sweet spot is around 30-40 ActiveMQ 
producers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to