[fineract] branch develop updated: Fix to update the client externalId (#2906)

[victorromero]

This is an automated email from the ASF dual-hosted git repository.

victorromero pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 679d297ad Fix to update the client externalId (#2906)
679d297ad is described below

commit 679d297ad5a23746dedbb97949325ea745b236e6
Author: José Alberto Hernández 
<44206706+josehernandezfintecheand...@users.noreply.github.com>
AuthorDate: Sat Jan 21 23:24:35 2023 -0600

    Fix to update the client externalId (#2906)
    
    Co-authored-by: Jose Alberto Hernandez <alberto@MacBook-Pro.local>
---
 .../client/service/ClientWritePlatformServiceJpaRepositoryImpl.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
index a44b6cad7..7e0af4e6c 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
@@ -430,7 +430,8 @@ public class ClientWritePlatformServiceJpaRepositoryImpl 
implements ClientWriteP
             }
 
             final ExternalId externalId = 
externalIdFactory.createFromCommand(command, 
ClientApiConstants.externalIdParamName);
-            if 
(command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName, 
externalId.getValue())) {
+            if 
(command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName,
+                    clientForUpdate.getExternalId().getValue())) {
                 changes.put(ClientApiConstants.externalIdParamName, 
externalId.getValue());
                 clientForUpdate.setExternalId(externalId);
             }