adamsaghy commented on code in PR #2908:
URL: https://github.com/apache/fineract/pull/2908#discussion_r1094155341
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntriesApiResource.java:
##########
@@ -166,7 +166,7 @@ public String retrieveAll(@Context final UriInfo uriInfo,
+
"journalentries/1?fields=officeName,glAccountId,entryType,amount\n" + "\n" +
"journalentries/1?runningBalance=true\n" + "\n"
+ "journalentries/1?transactionDetails=true")
@ApiResponses({
- @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation = JournalEntryData.class))) })
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
JournalEntriesApiResourceSwagger.GetJournalEntriesTransactionIdResponse.class)))
})
Review Comment:
This looks not right to me... This API is not returning the response with
paging. I think the one you are looking for is the `retrieveAl` method.
I reckon for this method the right swagger class would be
`JournalEntriesApiResourceSwagger.GetJournalEntriesTransactionIdResponse.JournalEntryTransactionPageItems.class`
However I would rename the `JournalEntryTransactionPageItems` to something
more generic like `JournalEntryTransactionItem`
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntriesApiResource.java:
##########
@@ -166,7 +166,7 @@ public String retrieveAll(@Context final UriInfo uriInfo,
+
"journalentries/1?fields=officeName,glAccountId,entryType,amount\n" + "\n" +
"journalentries/1?runningBalance=true\n" + "\n"
+ "journalentries/1?transactionDetails=true")
@ApiResponses({
- @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation = JournalEntryData.class))) })
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
JournalEntriesApiResourceSwagger.GetJournalEntriesTransactionIdResponse.class)))
})
Review Comment:
This looks not right to me... This API is not returning the response with
paging. I think the one you are looking for is the `retrieveAll` method.
I reckon for this method the right swagger class would be
`JournalEntriesApiResourceSwagger.GetJournalEntriesTransactionIdResponse.JournalEntryTransactionPageItems.class`
However I would rename the `JournalEntryTransactionPageItems` to something
more generic like `JournalEntryTransactionItem`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
