galovics commented on PR #2915: URL: https://github.com/apache/fineract/pull/2915#issuecomment-1416027468
> > > @galovics @b0c1 ... is there any reason why we use the database (global configuration service) to configure these things? Why wouldn't we put this in application.properties? > > > > > > @vidakovic we wanna be able to change the configuration value runtime. > > ... that is a solved problem in Spring/Boot (search: "reloadable configuration")... I'd say not a strong argument to bury it in the database... I'm not saying you're wrong but if I remember correctly reloading configuration is only supported with Spring Cloud and done by annotating classes with `@RefreshScope`. Now, upon refresh, you'll have the choice whether to just "refresh" the application context, reload or shutdown-reload it. I've used it with a cloud project but I think fineract in its current form is not suitable for this and could cause issues with context refreshes. **TL;DR;** I think going with refreshable properties with Spring's approach is way too premature for Fineract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
