adamsaghy commented on code in PR #2954:
URL: https://github.com/apache/fineract/pull/2954#discussion_r1097586045
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -129,15 +129,15 @@ private void
createJournalEntriesForChargeAdjustment(LoanDTO loanDTO, LoanTransa
Map<GLAccount, BigDecimal> accountMap = new HashMap<>();
// handle principal payment (and reversals)
- if (principalAmount != null &&
!(principalAmount.compareTo(BigDecimal.ZERO) == 0)) {
+ if (principalAmount != null &&
principalAmount.compareTo(BigDecimal.ZERO) != 0) {
Review Comment:
It should never happen, but still > 0 would be better... only positive
amount it can be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
