adamsaghy commented on code in PR #2953:
URL: https://github.com/apache/fineract/pull/2953#discussion_r1102708746


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualWritePlatformServiceImpl.java:
##########
@@ -289,6 +289,8 @@ public Map<String, Object> deriveAccountingBridgeData(final 
LoanScheduleAccrualD
         accountingBridgeData.put("upfrontAccrualBasedAccountingEnabled", 
false);
         accountingBridgeData.put("periodicAccrualBasedAccountingEnabled", 
true);
         accountingBridgeData.put("isAccountTransfer", false);
+        accountingBridgeData.put("isChargeOff", false);

Review Comment:
   Please mark this method to private to avoid anyone call it by mistake. Many 
of the fields are hardcoded specially for accrual transactions only!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to