galovics commented on code in PR #2986:
URL: https://github.com/apache/fineract/pull/2986#discussion_r1111671633
##########
fineract-provider/src/main/java/org/apache/fineract/notification/config/MessagingConfiguration.java:
##########
@@ -44,7 +44,7 @@ public class MessagingConfiguration {
private Environment env;
@Autowired
- private NotificationEventListener notificationEventListener;
+ private ActiveMQNotificationEventListener notificationEventListener;
Review Comment:
This is fine but I'd love to get rid of the spring profile for this
functionality and replace it with proper env variable configuration option.
This was rather a note and not a requirement from my side to get this PR in.
##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@
fineract.tenant.description=${FINERACT_DEFAULT_TENANTDB_DESCRIPTION:Default Demo
fineract.mode.read-enabled=${FINERACT_MODE_READ_ENABLED:true}
fineract.mode.write-enabled=${FINERACT_MODE_WRITE_ENABLED:true}
+fineract.mode.batch-enabled=${FINERACT_MODE_BATCH_ENABLED:true}
Review Comment:
There's no instance mode like this anymore, why was this required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
