adamsaghy commented on code in PR #3015:
URL: https://github.com/apache/fineract/pull/3015#discussion_r1121938380
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -198,7 +199,8 @@ public LoanTransaction makeRepayment(final
LoanTransactionType repaymentTransact
defaultLoanLifecycleStateMachine, existingTransactionIds,
existingReversedTransactionIds, isRecoveryRepayment,
scheduleGeneratorDTO, isHolidayValidationDone);
-
saveLoanTransactionWithDataIntegrityViolationChecks(newRepaymentTransaction);
+ newRepaymentTransaction =
saveLoanTransactionWithDataIntegrityViolationChecks(newRepaymentTransaction);
+
newRepaymentTransaction.setLoanChargesPaid(loanChargePaidByRepository.findByLoanTransaction(newRepaymentTransaction));
Review Comment:
I dont think we need this. The chargePaidBy associations are already
assigned to the loanTransaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
