galovics commented on code in PR #3017:
URL: https://github.com/apache/fineract/pull/3017#discussion_r1122286632


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -319,11 +318,12 @@ public Long getDailyTPTLimit() {
         return property.getValue();
     }
 
+    @CacheEvict(value = "configByName", key = 
"T(org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil).getTenant().getTenantIdentifier().concat(#propertyName)")
     @Override
     public void removeGlobalConfigurationPropertyDataFromCache(final String 
propertyName) {
-        String identifier = 
ThreadLocalContextUtil.getTenant().getTenantIdentifier();
-        String key = identifier + "_" + propertyName;
-        configurations.remove(key);
+        if (log.isDebugEnabled()) {

Review Comment:
   No need for the if, log.debug will just do the job. the isDebugEnabled check 
should be used when the value being logged is calculated and potentially 
expensive (for example making a DB call or something).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to