adamsaghy commented on code in PR #3030:
URL: https://github.com/apache/fineract/pull/3030#discussion_r1130887152
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java:
##########
@@ -206,6 +211,9 @@ private Long getLoanId(boolean isGlim, String pathInfo) {
if (isExternal(pathInfo)) {
String externalId = id;
return loanRepository.findIdByExternalId(new
ExternalId(externalId));
+ } else if (isRescheduleLoans(pathInfo)) {
+ return
loanRescheduleRequestRepository.findById(Long.valueOf(id)).map(LoanRescheduleRequest::getLoan)
Review Comment:
I think we should avoid to fetch the full loan here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
