vidakovic commented on code in PR #2981:
URL: https://github.com/apache/fineract/pull/2981#discussion_r1135243309


##########
build.gradle:
##########
@@ -55,6 +55,17 @@ buildscript {
     }
 }
 
+buildscript {

Review Comment:
   This is the wrong place to add this section (or the new plugin). Also: this 
seems to be the older way to add a Gradle plugin... which makes me a bit 
suspicious. When we upgrade to Gradle 8 (which is already out for a while) then 
these old plugins are very likely to break.
   Also: not sure if lower-/uppercase for log level etc. is really an issue 
here? If not required to change then please leave as is to keep the PR as 
minimal as possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to