[fineract] branch develop updated: [FINERACT-1724] revert removed loan repository query

[adamsaghy]

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 41651a6cb [FINERACT-1724] revert removed loan repository query
41651a6cb is described below

commit 41651a6cbbe56ea3ebcf44dc892e4a46c9b275a6
Author: taskain7 <task...@gmail.com>
AuthorDate: Thu Mar 16 11:01:26 2023 +0100

    [FINERACT-1724] revert removed loan repository query
---
 .../apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java  | 4 ++--
 .../apache/fineract/portfolio/loanaccount/domain/LoanRepository.java  | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java
 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java
index 8583f6dec..8c8cb4eb1 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java
@@ -148,8 +148,8 @@ public class LoanCOBApiFilter extends OncePerRequestFilter 
implements BatchFilte
     private boolean isLoanBehind(List<Long> loanIds) {
         List<LoanIdAndLastClosedBusinessDate> loanIdAndLastClosedBusinessDates 
= new ArrayList<>();
         List<List<Long>> partitions = Lists.partition(loanIds, 
fineractProperties.getQuery().getInClauseParameterSizeLimit());
-        partitions.forEach(partition -> 
loanIdAndLastClosedBusinessDates.addAll(loanRepository.findAllNonClosedLoansBehindOrNullByLoanIds(
-                
ThreadLocalContextUtil.getBusinessDateByType(BusinessDateType.COB_DATE), 
partition)));
+        partitions.forEach(partition -> 
loanIdAndLastClosedBusinessDates.addAll(loanRepository
+                
.findAllNonClosedLoansBehindByLoanIds(ThreadLocalContextUtil.getBusinessDateByType(BusinessDateType.COB_DATE),
 partition)));
         return CollectionUtils.isNotEmpty(loanIdAndLastClosedBusinessDates);
     }
 
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
index 2926fba7c..08e3cd0ef 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
@@ -192,6 +192,10 @@ public interface LoanRepository extends 
JpaRepository<Loan, Long>, JpaSpecificat
     @Query(FIND_ALL_NON_CLOSED_LOANS_BY_LAST_CLOSED_BUSINESS_DATE)
     List<Long> 
findAllNonClosedLoanIdsByLastClosedBusinessDate(@Param("businessDate") 
LocalDate businessDate);
 
+    @Query(FIND_ALL_NON_CLOSED_LOANS_BEHIND_BY_LOAN_IDS)
+    List<LoanIdAndLastClosedBusinessDate> 
findAllNonClosedLoansBehindByLoanIds(@Param("cobBusinessDate") LocalDate 
cobBusinessDate,
+            @Param("loanIds") List<Long> loanIds);
+
     @Query(FIND_ALL_NON_CLOSED_LOANS_BEHIND_OR_NULL_BY_LOAN_IDS)
     List<LoanIdAndLastClosedBusinessDate> 
findAllNonClosedLoansBehindOrNullByLoanIds(@Param("cobBusinessDate") LocalDate 
cobBusinessDate,
             @Param("loanIds") List<Long> loanIds);