adamsaghy commented on code in PR #3054:
URL: https://github.com/apache/fineract/pull/3054#discussion_r1140074161
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabasePasswordEncryptor.java:
##########
@@ -37,6 +38,20 @@ public class DatabasePasswordEncryptor implements
PasswordEncryptor {
private final FineractProperties fineractProperties;
+ //CHECKSTYLE:OFF
+ public static void main(String[] args) {
+ if (args.length < 2) {
+ System.out.println(
Review Comment:
Would it be better to use a logger here instead of System.out.println?
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabasePasswordEncryptor.java:
##########
@@ -37,6 +38,20 @@ public class DatabasePasswordEncryptor implements
PasswordEncryptor {
private final FineractProperties fineractProperties;
+ //CHECKSTYLE.OFF: IllegalCatch - Turn off checkstyle for main method
Review Comment:
You might wanna use this
`@SuppressWarnings("checkstyle:regexpsinglelinejava")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
