adamsaghy commented on code in PR #3073:
URL: https://github.com/apache/fineract/pull/3073#discussion_r1148947284
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -227,7 +230,7 @@ public LoanTransaction makeRepayment(final
LoanTransactionType repaymentTransact
}
postJournalEntries(loan, existingTransactionIds,
existingReversedTransactionIds, isAccountTransfer, isLoanToLoanTransfer);
-
+
loanAccrualTransactionBusinessEventService.raiseBusinessEventForAccrualTransactions(loan,
existingTransactionIds);
Review Comment:
Please raise the event after the "recalculateAccruals" method which might
created new Accrual transaction as well.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -405,6 +408,8 @@ public LoanTransaction makeChargePayment(final Loan loan,
final Long chargeId, f
}
postJournalEntries(loan, existingTransactionIds,
existingReversedTransactionIds, isAccountTransfer);
+
loanAccrualTransactionBusinessEventService.raiseBusinessEventForAccrualTransactions(loan,
existingTransactionIds);
Review Comment:
Please raise the event after the "recalculateAccruals" method which might
created new Accrual transaction as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
