galovics commented on code in PR #3076:
URL: https://github.com/apache/fineract/pull/3076#discussion_r1150825003
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -204,20 +204,37 @@ public DatatableData retrieveDatatable(final String
datatable) {
}
@Override
- public List<JsonObject> queryDataTable(String datatable, String
columnFilter, String valueFilter, String resultColumns) {
- Arrays.asList(datatable, columnFilter, valueFilter,
resultColumns).forEach(SQLInjectionValidator::validateDynamicQuery);
+ public List<JsonObject> queryDataTable(String datatable, String
columnFilter, String valueFilter, String resultColumns, Integer offset,
+ Integer limit, String orderBy, String sortOrder) {
+ Arrays.asList(datatable, columnFilter, valueFilter, resultColumns,
orderBy, sortOrder)
+ .forEach(SQLInjectionValidator::validateDynamicQuery);
List<ResultsetColumnHeaderData> resultsetColumnHeaderData =
genericDataService.fillResultsetColumnHeaders(datatable);
- validateRequestParams(columnFilter, valueFilter, resultColumns,
resultsetColumnHeaderData);
+ validateRequestParams(columnFilter, valueFilter, resultColumns,
resultsetColumnHeaderData, orderBy, sortOrder);
+
+ StringBuilder sql = new StringBuilder("select " + resultColumns + "
from " + datatable + " where " + columnFilter + " = ?");
Review Comment:
You should not concatenate the SQL, at all.
Use a parameterized query instead with placeholders, that'll be safe from
SQL injection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
