adamsaghy commented on code in PR #3100:
URL: https://github.com/apache/fineract/pull/3100#discussion_r1156613729
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java:
##########
@@ -110,6 +110,7 @@ public LoanDTO populateLoanDtoFromMap(final Map<String,
Object> accountingBridge
boolean isAccountTransfer = (Boolean)
accountingBridgeData.get("isAccountTransfer");
boolean isLoanMarkedAsChargeOff = (Boolean)
accountingBridgeData.get("isChargeOff");
boolean isLoanMarkedAsFraud = (Boolean)
accountingBridgeData.get("isFraud");
+ BigDecimal overpaidAmount = (BigDecimal)
accountingBridgeData.get("overpaidAmount");
Review Comment:
You dont need this, LoanTransactionDTO contains the overpaid amount
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -418,6 +418,7 @@ private void createJournalEntriesForChargeback(LoanDTO
loanDTO, LoanTransactionD
final Long loanProductId = loanDTO.getLoanProductId();
final Long loanId = loanDTO.getLoanId();
final String currencyCode = loanDTO.getCurrencyCode();
+ final BigDecimal overpaidAmount = loanDTO.getOverpaidAmount();
Review Comment:
final BigDecimal overPaymentAmount = loanTransactionDTO.getOverPayment();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
