adamsaghy commented on code in PR #3112:
URL: https://github.com/apache/fineract/pull/3112#discussion_r1163817561
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanItemReader.java:
##########
@@ -36,7 +39,9 @@ public LoanItemReader(LoanRepository loanRepository) {
@SuppressWarnings({ "unchecked" })
public void beforeStep(@NotNull StepExecution stepExecution) {
ExecutionContext executionContext =
stepExecution.getExecutionContext();
- List<Long> loanIds = (List<Long>)
executionContext.get(LoanCOBConstant.LOAN_IDS);
+ LoanCOBMinANdMaxLoanId loanCOBMinANdMaxLoanId =
(LoanCOBMinANdMaxLoanId) executionContext.get(LoanCOBConstant.LOAN_IDS);
+ List<Long> loanIds =
loanRepository.findAllNonClosedLoansBehindOrNullByMinAndMaxLoanId(loanCOBMinANdMaxLoanId.getMinLoanId(),
Review Comment:
NPE if `loanCOBMinANdMaxLoanId` is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
