[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #3122: FINERACT-1757: Uppercase letters in the datatable name is failing on …

[via GitHub]

josehernandezfintecheandomx opened a new pull request, #3122:
URL: https://github.com/apache/fineract/pull/3122

   …postgres
   
   ## Description
   
   There is no restriction on the datatables whether they can contain uppercase 
letters.
   
   It was working just fine with Mysql and Mariadb as it was automatically 
converted all of them on saving and looking up.
   
   However postgres is working differently. It will fail on the lookup if the 
provided table names contains uppercase letters.
   
   [FINERACT-1757](https://issues.apache.org/jira/browse/FINERACT-1757)
   
   - SQL samble generated with the table name `scaped` 
   <img width="1734" alt="Screenshot 2023-04-14 at 0 11 50" 
src="https://user-images.githubusercontent.com/44206706/231958768-649542c8-f051-413e-b708-244eba9fa887.png";>
   
   - Datatable API call using the `query` option to filter results
   <img width="1000" alt="Screenshot 2023-04-14 at 0 19 29" 
src="https://user-images.githubusercontent.com/44206706/231959292-60c816b3-1a7d-4395-9746-26ce7a7993cc.png";>
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org