adamsaghy commented on code in PR #3132:
URL: https://github.com/apache/fineract/pull/3132#discussion_r1170998041
##########
fineract-provider/src/main/java/org/apache/fineract/cob/service/AsyncLoanCOBExecutorServiceImpl.java:
##########
@@ -47,26 +46,31 @@
import org.springframework.batch.core.repository.JobRestartException;
import org.springframework.scheduling.annotation.Async;
import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Propagation;
+import org.springframework.transaction.annotation.Transactional;
@Service
@RequiredArgsConstructor
public class AsyncLoanCOBExecutorServiceImpl implements
AsyncLoanCOBExecutorService {
- private final LoanRepository loanRepository;
private final JobLocator jobLocator;
private final ScheduledJobDetailRepository scheduledJobDetailRepository;
private final JobStarter jobStarter;
private final JobParameterRepository jobParameterRepository;
private final RetrieveLoanIdService retrieveLoanIdService;
+ private final LoanAccountLockService accountLockService;
@Override
@Async("loanCOBCatchUpThreadPoolTaskExecutor")
+ @Transactional(propagation = Propagation.REQUIRED)
Review Comment:
Is this required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
