taskain7 commented on code in PR #3195:
URL: https://github.com/apache/fineract/pull/3195#discussion_r1203665104
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -27,7 +29,15 @@
public interface ExternalAssetOwnerTransferRepository
extends JpaRepository<ExternalAssetOwnerTransfer, Long>,
JpaSpecificationExecutor<ExternalAssetOwnerTransfer> {
- @Query("select e from ExternalAssetOwnerTransfer e where (:loanId is null
or e.loanId = :loanId) and (:loanExternalId is null or e.externalLoanId =
:loanExternalId) and (:transferExternalId is null or e.externalId =
:transferExternalId)")
- List<ExternalAssetOwnerTransfer> findAllByIncomingId(@Param("loanId") Long
loanId, @Param("loanExternalId") String loanExternalId,
- @Param("transferExternalId") String transferExternalId);
+ @Query("select e from ExternalAssetOwnerTransfer e where e.loanId =
:loanId")
+ List<ExternalAssetOwnerTransfer> findAllByLoanId(@Param("loanId") Long
loanId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalLoanId
= :externalId")
Review Comment:
fixed
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -27,7 +29,15 @@
public interface ExternalAssetOwnerTransferRepository
extends JpaRepository<ExternalAssetOwnerTransfer, Long>,
JpaSpecificationExecutor<ExternalAssetOwnerTransfer> {
- @Query("select e from ExternalAssetOwnerTransfer e where (:loanId is null
or e.loanId = :loanId) and (:loanExternalId is null or e.externalLoanId =
:loanExternalId) and (:transferExternalId is null or e.externalId =
:transferExternalId)")
- List<ExternalAssetOwnerTransfer> findAllByIncomingId(@Param("loanId") Long
loanId, @Param("loanExternalId") String loanExternalId,
- @Param("transferExternalId") String transferExternalId);
+ @Query("select e from ExternalAssetOwnerTransfer e where e.loanId =
:loanId")
+ List<ExternalAssetOwnerTransfer> findAllByLoanId(@Param("loanId") Long
loanId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalLoanId
= :externalId")
+ List<ExternalAssetOwnerTransfer>
findAllByLoanExternalId(@Param("externalId") ExternalId externalId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalId =
:externalId")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
