galovics commented on code in PR #3198:
URL: https://github.com/apache/fineract/pull/3198#discussion_r1203854731
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/LoanDelinquencyDomainServiceImpl.java:
##########
@@ -141,7 +141,12 @@ public CollectionData getOverdueCollectionData(final Loan
loan) {
collectionData.setDelinquentAmount(outstandingAmount);
if (overdueDays > 0) {
- collectionData.setDelinquentDays(overdueDays - graceDays);
+ Long delinquentDays = 0L;
Review Comment:
So what's the point of this variable? Why aren't you doing is a simpler way?
```
collectionData.setDelinquentDays(0);
Long delinquentDays = overdueDays - graceDays;
if (delinquentDays > 0) {
collectionData.setDelinquentDays(delinquentDays);
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
