adamsaghy commented on code in PR #3201:
URL: https://github.com/apache/fineract/pull/3201#discussion_r1205150551
##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -117,7 +118,8 @@ private void
validateSettlementDate(ExternalAssetOwnerTransfer externalAssetOwne
}
private void validateLoanStatus(LoanIdAndExternalIdData
loanIdAndExternalIdAndExternalId) {
- if (Objects.isNull(loanIdAndExternalIdAndExternalId)) {
+ if (Objects.isNull(loanIdAndExternalIdAndExternalId.getLoanId())
Review Comment:
Its a little bit ambigous... we will get the same error even the Loan is not
even existing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
