adamsaghy commented on code in PR #3200:
URL: https://github.com/apache/fineract/pull/3200#discussion_r1206346281
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java:
##########
@@ -184,17 +184,12 @@ private List<Long> getGlimChildLoanIds(Long
loanIdFromRequest) {
}
}
- private boolean isLoanSoftLocked(List<Long> loanIds) {
- return isLoanLocked(loanIds, false);
- }
-
private boolean isLoanHardLocked(List<Long> loanIds) {
return isLoanLocked(loanIds, true);
}
private boolean isLoanLocked(List<Long> loanIds, boolean isHardLock) {
- return isHardLock ?
loanIds.stream().anyMatch(loanAccountLockService::isLoanHardLocked)
- :
loanIds.stream().anyMatch(loanAccountLockService::isLoanSoftLocked);
+ return
loanIds.stream().anyMatch(loanAccountLockService::isLoanHardLocked);
Review Comment:
you might wanna remove the `isHardLock` parameter. It is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
